home-assistant-custom-components.cync_lights: init at 1.0.1 #336816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndarwincorn
commented
Aug 23, 2024
ndarwincorn
force-pushed
the
init-cync_lights
branch
2 times, most recently
from
5dd526a to
7a08424
Compare
mweinelt
reviewed
Aug 23, 2024
pkgs/servers/home-assistant/custom-components/cync_lights/default.nix
Outdated
Show resolved
Hide resolved
mweinelt
reviewed
Aug 23, 2024
pkgs/servers/home-assistant/custom-components/cync_lights/default.nix
Outdated
Show resolved
Hide resolved
mweinelt
reviewed
Aug 23, 2024
| description = "Home Assistant Integration for controlling Cync switches, plugs, and bulbs"; | ||
| homepage = "https://github.com/nikshriv/cync_lights"; | ||
| maintainers = with maintainers; [ ndarwincorn ]; | ||
| license = licenses.unlicensed; |
There was a problem hiding this comment.
That is not a valid license, and upstream has no license, so copyright likely applies. Please clarify the situation with upstream.
There was a problem hiding this comment.
Will update once the repo is licensed.
ndarwincorn
force-pushed
the
init-cync_lights
branch
from
aeb5d55 to
68e88d9
Compare
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Initializes the cync_lights custom component at 1.0.1.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.