feat: implement the solidity compilation cache #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
galargh
force-pushed
the
build-system-cache
branch
from
1807993 to
a1d4dca
Compare
hardhatTotal size of the bundle: List of dependencies (sorted by size) |
galargh
force-pushed
the
build-system-cache
branch
from
a1d4dca to
ae3401d
Compare
galargh
force-pushed
the
build-system-cache
branch
from
ae3401d to
db3ac09
Compare
galargh
force-pushed
the
build-system-cache
branch
from
db3ac09 to
73ba8e0
Compare
galargh
commented
Jan 30, 2025
|
|
||
| import { ResolvedFileType } from "../../../../types/solidity.js"; | ||
|
|
||
| export class ProjectResolvedFileImplementation implements ProjectResolvedFile { |
There was a problem hiding this comment.
Context
I add implementations of ProjectResolvedFile and NpmPackageResolvedFile interfaces here. These are necessary in order to lazily store content hashes on them, as proposed as part of the getBuildId optimisations.
galargh
commented
Jan 30, 2025
| @@ -35,14 +35,15 @@ export interface ResolvedNpmPackage { | |||
| */ | |||
| export enum ResolvedFileType { | |||
| PROJECT_FILE = "PROJECT_FILE", | |||
| NPM_PACKGE_FILE = "NPM_PACKAGE_FILE", | |||
| NPM_PACKAGE_FILE = "NPM_PACKAGE_FILE", | |||
| } | |||
|
|
|||
| /** | |||
| * A file that's part of the Hardhat project (i.e. not installed through npm). | |||
| */ | |||
| export interface ProjectResolvedFile { | |||
There was a problem hiding this comment.
Context
I add getContentHash() methods on the ProjectResolvedFile and NpmPackageResolvedFile interfaces here. These functions are needed to implement the getBuildId optimisations.
alcuadrado
reviewed
Feb 4, 2025
| @@ -17,17 +15,22 @@ export async function keccak256(bytes: Uint8Array): Promise<Uint8Array> { | |||
| * | |||
| * This function is primarily intended for generating unique identifiers from | |||
| * a given input string. | |||
| * It uses the MD5 hash algorithm, which is not cryptographically secure, but | |||
| * It uses the SHA-1 hash algorithm, which is not cryptographically secure, but | |||
alcuadrado
reviewed
Feb 4, 2025
alcuadrado
reviewed
Feb 4, 2025
alcuadrado
reviewed
Feb 6, 2025
v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/cache.ts
Outdated
Show resolved
Hide resolved
alcuadrado
reviewed
Feb 6, 2025
v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/cache.ts
Outdated
Show resolved
Hide resolved
alcuadrado
reviewed
Feb 6, 2025
v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/build-system.ts
Show resolved
Hide resolved
alcuadrado
reviewed
Feb 6, 2025
v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/build-system.ts
Outdated
Show resolved
Hide resolved
alcuadrado
reviewed
Feb 6, 2025
| buildId, | ||
| contractArtifactsGenerated: | ||
| contractArtifactsGenerated.get(publicSourceName) ?? [], | ||
| warnings: errors, |
There was a problem hiding this comment.
self-answer: yes, these warnings have been remapped
galargh
commented
Feb 6, 2025
Comment on lines
+722
to
+724
| * If we notice that the amount of write failures is too high, or that the | ||
| * cache is not getting cleaned up often enough, we should reconsider this | ||
| * approach. |
There was a problem hiding this comment.
FYI, I included some of the reasons why we might have to end up awaiting the cache update after all. I think we can start with this version and reconsider if/when needed.
alcuadrado
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I implement the solidity compilation cache as outlined in the associated design doc.
The implementation diverges from the design doc in 1 areas: