ignition: port ignition plugin #6227
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hardhatTotal size of the bundle: List of dependencies (sorted by size) |
kanej
added
no changeset needed
kanej
force-pushed
the
feat/port-ignition-ui
branch
2 times, most recently
from
cc6c292 to
4edf391
Compare
kanej
force-pushed
the
feat/port-ignition-plugin
branch
from
1679340 to
0003363
Compare
kanej
force-pushed
the
feat/port-ignition-plugin
branch
from
816df90 to
d6150c4
Compare
A mechanical move of the files to under `./v-next`. This is the core plugin with the cli tasks.
Note we are removing the `hardhat-verify` dependency for the moment, it has not been ported to `v-next`.
Bring back a working `pnpm clean` command by bringing rimraf in line with v-next.
Pull in the new tsconfig.json settings.
Rename the ignition-core imports to use the new names.
This was a mechanical transform from applying `(import\s+[^'"]+['"])(\..*?)(['"])` with `$1$2.js$3` as the replacement.
This is a set of changes that are small and non-controversial. The following commits will turn different parts of the codebase off.
The core index code will change radically. It will be brought back a task at a time once we have the new Hardhat 3 plugin boiler plate in place.
One point for the future is isolated declrations does not work with Ignition module files nicely.
There are some exclusions. We need to revisit those.
This is mainly eslint --fix. However there are a few other tweaks.
Move some further HardhatPluginError usages and stray assertion errors.
Bump the version of mocha and related packages to versions that support ESM. Update the config and commands appropriately. The pattern is modelled on the changes from `ignition-core`.
Remove the dep and replace with the v-next hardhat utils. The usages have updated to match the equivalent function in utils.
kanej
force-pushed
the
feat/port-ignition-plugin
branch
from
5a55b98 to
b0a6c56
Compare
There is a new version of it coming that is ESM compatible. For the moment we will dynamically import it.
Any tests use a project fixture has been set to skipped. The usage of json5 was updated to reflect that it used a default export.
This commit pulls in the new version of Hardhat. It updates code and tests but only to the level of building. Fixture tests remain turned off. The code changes where forced by the changes in the main types e.g. HRE.
A copy and paste error missed a few on dealing with a merge.
This is in prep for including it in the example project.
Add a plugin to index.ts with a single task of deploy. The task is a placeholder.
This is to help with local testing.
We take the existing commented out deploy code and move it into a task file. To do this we also: * update `fs-extra` usages to `hardhat-utils` * bring back the type extensions for config * bring back the config tests * add in a config hook to resolve ignitions config at both top and network level
This will get fixed up with post-alpha improvements in the plugin API.
kanej
force-pushed
the
feat/port-ignition-plugin
branch
from
b0a6c56 to
90d7b95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate @nomicfoundation/hardhat-ignition, the core CLI plugin.
TODO
Review points
.replace("workspace:", "")for the npm version checkFollow-up tasks
""to represent no option given by user