Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump markdownlint to 0.13.0 #91

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 1, 2023

Bump markdownlint to 0.13.0.

Also, rewrite the rule config to ignore the issues instead of listing the allowed ones. Makes it clearer and more futureproof. Actual fixing of the issues should be done in some future commit.

TODO: bump in project-infra when all repos are bumped.

/hold
until metal3-io/project-infra#600 is merged, so the rule config is actually tested.

Bump markdownlint to 0.13.0.

Also, rewrite the rule config to ignore the issues instead of listing
the allowed ones. Makes it clearer and more futureproof. Actual fixing
of the issues should be done in some future commit.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

/retest
To activate the markdownlint check when changing the script itself added in Prow.
/unhold

Copy link
Contributor

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

@smoshiur1237 can you also add the lgtm

Copy link
Contributor

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Member

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Rozzii,kashifest,smoshiur1237]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 6cdb884 into main Dec 1, 2023
1 check passed
@tuminoid tuminoid deleted the tuomo/bump-markdownlint branch December 1, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants