Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update TLS profile document of the Metal3 stack #94

Merged
merged 1 commit into from
Feb 2, 2024
Merged

update TLS profile document of the Metal3 stack #94

merged 1 commit into from
Feb 2, 2024

Conversation

Rozzii
Copy link
Contributor

@Rozzii Rozzii commented Jan 29, 2024

This commit updates:

  • TLS profile of Ironic/IPA
  • TLS profile of etcd

@Rozzii Rozzii requested a review from tuminoid January 29, 2024 08:47
tuminoid
tuminoid reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update Adam. Couple nits.

@Rozzii Rozzii requested a review from tuminoid January 30, 2024 14:48
tuminoid
tuminoid previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks, I see you made other improvements as well.

@tuminoid
Copy link
Member

tuminoid commented Feb 1, 2024

/cc @kashifest

kashifest
kashifest reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only few nits

smoshiur1237
smoshiur1237 reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestion to improve the readability. I would suggest to avoid long sentences and break them in smaller parts.

@Rozzii
update TLS profile document of the Metal3 stack
2d1bfb4 
This commit updates:

- TLS profile of Ironic/IPA
- TLS profile of etcd

Signed-off-by: Adam Rozman <adam.rozman@est.tech>
@kashifest
Copy link
Contributor

/approve

@kashifest
Copy link
Contributor

/lgtm

@metal3-io-bot
Copy link
Member

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 253e539 into main Feb 2, 2024
3 checks passed
@metal3-io-bot metal3-io-bot deleted the update-tls branch February 2, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid approved these changes

@kashifest kashifest kashifest approved these changes

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees

@kashifest kashifest

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rozzii @tuminoid @kashifest @metal3-io-bot @smoshiur1237