Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: format all YAML consistently as k8s yaml #95

Closed
wants to merge 1 commit into from

Conversation

tuminoid
Copy link
Member

This PR formats all YAML files (*.yaml, *.yml) by the k8s YAML
formatting style. Ie. no indentation for lists, removing leading ---
for multi-document YAML files (it is not necessary) etc.

Similar PR is made in every repository for Metal3.

Signed-off-by: Tuomo Tanskanen tuomo.tanskanen@est.tech

This PR formats all YAML files (*.yaml, *.yml) by the k8s YAML
formatting style. Ie. no indentation for lists, removing leading ---
for multi-document YAML files (it is not necessary) etc.

Similar PR is made in every repository for Metal3.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot
Copy link
Member

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tuminoid. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid tuminoid changed the title WIP: format all YAML consistently as k8s yaml format all YAML consistently as k8s yaml Jan 30, 2024
@tuminoid tuminoid changed the title format all YAML consistently as k8s yaml WIP: format all YAML consistently as k8s yaml Jan 30, 2024
@tuminoid
Copy link
Member Author

Otherwise OK, but not fond of the unexpected formatting with the long descriptions.

@tuminoid
Copy link
Member Author

To be done on a later date, if a satisfying solution to formatting is found. For now,

/close

@metal3-io-bot
Copy link
Member

@tuminoid: Closed this PR.

In response to this:

To be done on a later date, if a satisfying solution to formatting is found. For now,

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/yaml-formatting branch May 15, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants