Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove folder wow moved to metal3-clusterapi-docs #748

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Remove folder wow moved to metal3-clusterapi-docs #748

merged 1 commit into from
Apr 10, 2024

Conversation

mboukhalfa
Copy link
Contributor

No description provided.

@tuminoid
Copy link
Member

tuminoid commented Feb 1, 2024

/hold
Nordix/metal3-clusterapi-docs#96 needs to merge first.

mboukhalfa
mboukhalfa commented Feb 1, 2024
View reviewed changes
wow/fullstack-build.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
this need to be moved after merging metal3-io/project-infra#629

Sunnatillo
Sunnatillo reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Sunnatillo
Copy link
Member

/override test-integration-metal3-dev-tools-centos
/override test-integration-metal3-dev-tools-ubuntu

@metal3-io-bot
Copy link
Member

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: test-integration-metal3-dev-tools-centos, test-integration-metal3-dev-tools-ubuntu

In response to this:

/override test-integration-metal3-dev-tools-centos
/override test-integration-metal3-dev-tools-ubuntu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tuminoid
tuminoid approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Member

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboukhalfa
Copy link
Contributor Author

/hold cancel
PR merged

@metal3-io-bot metal3-io-bot merged commit d074376 into main Apr 10, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the Remove-moved-wow/mohammed branch April 10, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@tuminoid tuminoid tuminoid approved these changes

Assignees

@Sunnatillo Sunnatillo

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mboukhalfa @tuminoid @Sunnatillo @metal3-io-bot