Fix nonpositive weights bug (#87)

* Fix nonpositive weights bug --------- Co-authored-by: José Bayoán Santiago Calderón <naoyabpr@gmail.com>
Nosferican · Dec 9, 2024 · a622c52 · a622c52 · Nosferican · Dec 9, 2024
1 parent 032c0f2
commit a622c52
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/src/formula.jl b/src/formula.jl
@@ -56,7 +56,7 @@ function decompose(
         convert(Vector{Symbol}, filter!(!isnothing, union(termvars(f), [panel, time, wts])))
     data = select(data, pns...) |> columntable
     if isa(wts, Symbol)
-        wts = ifelse.(getproperty(data, wts) .≤ 0, missing, getproperty(data, wts))
+        data = (data..., wts = ifelse.(getproperty(data, wts) .≤ 0, missing, getproperty(data, wts)))
     end
     categorical_variables =
         Tables.schema(data) |> (
@@ -158,7 +158,7 @@ function decompose(
         Z = zeros(0, 0)
     end
     wts =
-        isnothing(wts) ? FrequencyWeights(ones(length(y))) : FrequencyWeights(collect(wts))
+        isnothing(wts) ? FrequencyWeights(ones(length(y))) : FrequencyWeights(collect(getproperty(data, wts)))
     if isa(estimator, Type{<:RandomEffectsEstimator})
         panel = (
             panel,

diff --git a/test/issues.jl b/test/issues.jl
@@ -0,0 +1,11 @@
+@testset "Issues" begin
+    @testset "Nonpositive Weights" begin
+        x = randn(100)
+        y = 2*x + randn(100)
+        w = randn(100)
+        data = DataFrame(x = x, y = y, w = w)
+        # Test that no error is thrown
+        # https://github.com/JuliaLang/julia/issues/18780#issuecomment-251534863
+        @test fit(EconometricModel, @formula(y ~ x), data; wts = :w) isa Any
+    end
+end
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -12,6 +12,7 @@ for file in [
     "ologit",
     "formula_display",
     "mlj",
+    "issues",
     "docs"
     ]
     include("$file.jl")