Added Embedded Resource Capability #6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Mar 6, 2025
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/Package/EmbeddedResourcesCapability.cs
Outdated
Show resolved
Hide resolved
jebriede
reviewed
Mar 6, 2025
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/Package/EmbeddedResourcesCapability.cs
Outdated
Show resolved
Hide resolved
| private INuGetPackageFileService _nugetPackageFileService; | ||
| private PackageModel _package; | ||
|
|
||
| public EmbeddedResourcesCapability(INuGetPackageFileService nugetPackageFileService, PackageModel package, Uri? iconUri, Uri? licenseUri, Uri? readmeUri) |
There was a problem hiding this comment.
If it's possible to have a License and not a README or icon, should these be separate classes instead? Otherwise, should these be required parameters?
There was a problem hiding this comment.
It's possible, but the capabilities are added in the package definitions, right? I don't know if there's a type of package that only includes one of the embedded resources.
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/Package/EmbeddedResourcesCapability.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/Package/EmbeddedResourcesCapability.cs
Outdated
Show resolved
Hide resolved
...nts.Tests/NuGet.PackageManagement.UI.Test/Models/Package/EmbeddedResourcesCapabilityTests.cs
Outdated
Show resolved
Hide resolved
...nts.Tests/NuGet.PackageManagement.UI.Test/Models/Package/EmbeddedResourcesCapabilityTests.cs
Outdated
Show resolved
Hide resolved
...nts.Tests/NuGet.PackageManagement.UI.Test/Models/Package/EmbeddedResourcesCapabilityTests.cs
Outdated
Show resolved
Hide resolved
...nts.Tests/NuGet.PackageManagement.UI.Test/Models/Package/EmbeddedResourcesCapabilityTests.cs
Outdated
Show resolved
Hide resolved
...nts.Tests/NuGet.PackageManagement.UI.Test/Models/Package/EmbeddedResourcesCapabilityTests.cs
Outdated
Show resolved
Hide resolved
...nts.Tests/NuGet.PackageManagement.UI.Test/Models/Package/EmbeddedResourcesCapabilityTests.cs
Outdated
Show resolved
Hide resolved
jeffkl
approved these changes
Mar 6, 2025
jebriede
approved these changes
Mar 8, 2025
...nts.Tests/NuGet.PackageManagement.UI.Test/Models/Package/EmbeddedResourcesCapabilityTests.cs
Outdated
Show resolved
Hide resolved
...nts.Tests/NuGet.PackageManagement.UI.Test/Models/Package/EmbeddedResourcesCapabilityTests.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/Package/EmbeddedResourcesCapability.cs
Outdated
Show resolved
Hide resolved
jgonz120
merged commit edc3394
into
dev-feature-PackageDomainModel
1 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3198
Description
Added new capability for downloading embedded resources for packages.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.