-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Cake tab with instructions for NuGet packages #8434
Implementation of Cake tab with instructions for NuGet packages #8434
Conversation
tests/NuGetGallery.Facts/Extensions/CakeBuildManagerExtensionsFacts.cs
Outdated
Show resolved
Hide resolved
/cc @jcjiang and @JonDouglas, could you take a look? I have a couple code level comment but I'd like your input on:
|
@augustoproiete - could we split out the .NET tools change to another PR? The .NET tool part was not reviewed by the team when I presented your proposal internally and we would need more feedback from the .NET CLI folks for the .NET tools change. They essentially own that experience and should be included in the discussion. (similar to the local tools proposal you have) We can block this PR on that discussion or we can split out the .NET tool part and have a separate proposal/discussion/PR on it (that will probably be quicker E2E than this one but is earlier in the lifecycle than the proposal associated with this PR). It's up to you! |
@joelverhagen Thanks for the review!! I'll address the code-level comments later tonight, and will move the .NET Tools part to a separate PR so it doesn't block the other features from moving forward. |
@joelverhagen This is ready for round 2. All your comments have been addressed. I removed the Cake tab from .NET Tool packages, and will send a separate PR with that. |
tests/NuGetGallery.Facts/Extensions/CakeBuildManagerExtensionsFacts.cs
Outdated
Show resolved
Hide resolved
This is looking really good. @NuGet/gallery-team - could I get another pair of eyes on here? |
…ta] to match codebase conventions
This reverts commit 5a3b096.
@joelverhagen This is ready for round 3. All your comments have been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great work. 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green. Great work!
🚢 |
Add installation instructions of NuGet packages in Cake scripts.
Credits to Nils Andresen ( @nils-a ), member of the Cake team, who did all the hard work 💪
Dependency
that have the tagcake-addin
Dependency
that have the tagcake-module
Dependency
that have the tagcake-recipe
Dependency
/cc @joelverhagen
Addresses #8381