fix: avoid to array mutation (#17)

ember-composable-helpers/src/helpers/find-by.ts

@@ -1,14 +1,14 @@
 import { helper } from '@ember/component/helper';
 import { isEmpty } from '@ember/utils';
-import { A as emberArray } from '@ember/array';
+import { get } from "@ember/object";
 import asArray from '../utils/as-array.ts';
 
 export function findBy<T>([byPath, value, array]: [keyof T, T[keyof T], T[]]) {
   if (isEmpty(byPath)) {
     return [];
   }
 
-  return emberArray(asArray(array)).findBy(byPath, value);
+  return asArray(array).find((item) => get(item, String(byPath)) === value);
 }
 
 export default helper(findBy);

ember-composable-helpers/src/helpers/includes.ts

@@ -1,4 +1,3 @@
-import { A as emberArray } from '@ember/array';
 import { isArray as isEmberArray } from '@ember/array';
 import { helper } from '@ember/component/helper';
 import asArray from '../utils/as-array.ts';
@@ -9,7 +8,7 @@ export function includes<T>(needleOrNeedles: T | T[], haystack: T[]) {
   }
 
   let needles = isEmberArray(needleOrNeedles) ? needleOrNeedles : [needleOrNeedles];
-  let haystackAsEmberArray = emberArray(asArray(haystack));
+  let haystackAsEmberArray = asArray(haystack);
 
   return asArray(needles as T[]).every((needle) => {
     return haystackAsEmberArray.includes(needle);

ember-composable-helpers/src/helpers/next.ts

@@ -1,7 +1,6 @@
 import { helper } from '@ember/component/helper';
 import getIndex from '../utils/get-index.ts';
 import { isEmpty } from '@ember/utils';
-import { A as emberArray } from '@ember/array';
 import getValueArrayAndUseDeepEqualFromParams from '../-private/get-value-array-and-use-deep-equal-from-params.ts';
 import asArray from '../utils/as-array.ts';
 
@@ -14,7 +13,7 @@ export function next<T>(currentValue: T, maybeArray: T[], useDeepEqual = false)
     return;
   }
 
-  return currentIndex === lastIndex ? currentValue : emberArray(array).objectAt(currentIndex + 1);
+  return currentIndex === lastIndex ? currentValue : array.at(currentIndex + 1);
 }
 
 export default helper(function<T>(params: [T, boolean | T[], T[]?]) {

ember-composable-helpers/src/helpers/previous.ts

@@ -1,8 +1,7 @@
-import { helper } from '@ember/component/helper';
-import getIndex from '../utils/get-index.ts';
-import { isEmpty } from '@ember/utils';
-import { A as emberArray } from '@ember/array';
-import getValueArrayAndUseDeepEqualFromParams from '../-private/get-value-array-and-use-deep-equal-from-params.ts';
+import { helper } from "@ember/component/helper";
+import getIndex from "../utils/get-index.ts";
+import { isEmpty } from "@ember/utils";
+import getValueArrayAndUseDeepEqualFromParams from "../-private/get-value-array-and-use-deep-equal-from-params.ts";
 
 export function previous<T>(currentValue: T, array: T[], useDeepEqual = false) {
   let currentIndex = getIndex(array, currentValue, useDeepEqual) as number;
@@ -11,11 +10,12 @@ export function previous<T>(currentValue: T, array: T[], useDeepEqual = false) {
     return;
   }
 
-  return currentIndex === 0 ? currentValue : emberArray(array).objectAt(currentIndex - 1);
+  return currentIndex === 0 ? currentValue : array.at(currentIndex - 1);
 }
 
-export default helper(function<T>(params: [T, boolean | T[], T[]?]) {
-  let { currentValue, array, useDeepEqual } = getValueArrayAndUseDeepEqualFromParams(params);
+export default helper(function <T>(params: [T, boolean | T[], T[]?]) {
+  let { currentValue, array, useDeepEqual } =
+    getValueArrayAndUseDeepEqualFromParams(params);
 
   return previous(currentValue, array as T[], useDeepEqual);
 });

ember-composable-helpers/src/utils/get-index.ts

@@ -1,16 +1,19 @@
-import { A as emberArray } from '@ember/array';
-import isEqual from '../utils/is-equal.ts';
+import isEqual from "../utils/is-equal.ts";
 
-export default function getIndex<T>(array: T[], currentValue: T, useDeepEqual: boolean) {
+export default function getIndex<T>(
+  array: T[],
+  currentValue: T,
+  useDeepEqual: boolean
+) {
   let needle = currentValue;
 
   if (useDeepEqual) {
-    needle = emberArray(array).find((object) => {
+    needle = array.find((object) => {
       return isEqual(object, currentValue, useDeepEqual);
     }) as T;
   }
 
-  let index = emberArray(array).indexOf(needle);
+  let index = (array || []).indexOf(needle);
 
   return index >= 0 ? index : null;
 }

ember-composable-helpers/tsconfig.json

@@ -8,6 +8,7 @@
     "environment": ["ember-loose", "ember-template-imports"]
   },
   "compilerOptions": {
+    "target": "es2022",
     "allowJs": true,
     "declarationDir": "declarations",
     /**

test-app-min-supported-classic/tests/integration/helpers/includes-test.js

@@ -51,7 +51,15 @@ module('Integration | Helper | {{includes}}', function(hooks) {
 
     assert.dom().hasText('true', 'should render true');
 
-    run(() => this.get('wishlist').removeObject(games[0]));
+    assert.dom().hasText('true', 'should render true');
+    assert.true(!this.wishlist.removeObject, 'should not extend the array with additional functions')
+
+    run(() =>
+      this.set(
+        "wishlist",
+        this.wishlist.filter((game) => game !== games[0])
+      )
+    );
 
     assert.dom().hasText('false', 'should render false');
 

test-app-min-supported/tests/integration/helpers/includes-test.js

@@ -51,7 +51,15 @@ module('Integration | Helper | {{includes}}', function(hooks) {
 
     assert.dom().hasText('true', 'should render true');
 
-    run(() => this.get('wishlist').removeObject(games[0]));
+    assert.dom().hasText('true', 'should render true');
+    assert.true(!this.wishlist.removeObject, 'should not extend the array with additional functions')
+
+    run(() =>
+      this.set(
+        "wishlist",
+        this.wishlist.filter((game) => game !== games[0])
+      )
+    );
 
     assert.dom().hasText('false', 'should render false');
 

test-app/tests/integration/helpers/find-by-test.js

@@ -39,6 +39,7 @@ module('Integration | Helper | {{find-by}}', function(hooks) {
     `);
 
     assert.dom().hasText('b', 'b is shown');
+    assert.true(!this.array.removeObject, 'should not extend the array with additional functions')
   });
 
   test('It recomputes the filter if array changes', async function(assert) {

test-app/tests/integration/helpers/includes-test.js

@@ -50,8 +50,14 @@ module('Integration | Helper | {{includes}}', function(hooks) {
     await render(hbs`{{includes this.selectedGame this.wishlist}}`);
 
     assert.dom().hasText('true', 'should render true');
-
-    run(() => this.get('wishlist').removeObject(games[0]));
+    assert.true(!this.wishlist.removeObject, 'should not extend the array with additional functions')
+
+    run(() =>
+      this.set(
+        "wishlist",
+        this.wishlist.filter((game) => game !== games[0])
+      )
+    );
 
     assert.dom().hasText('false', 'should render false');