Install TypeScript, add template registry #13

charlesfries · 2024-05-17T22:16:34Z

No description provided.

lukasnys · 2024-06-26T11:30:28Z

This is awesome! Anything that can be done to help move this forward?

charlesfries · 2024-06-26T17:12:29Z

@lukasnys I just need some help installing TypeScript in a V2 addon. Not sure exactly what files and deps are needed

lukasnys · 2024-06-27T06:55:42Z

@charlesfries I couldn't immediately find a list of commands to easily add TypeScript to a V2 addon. I tried using ember-cli-update and passing the --typescript flag to the blueprint but that didn't work unfortunately.

I then took a different approach and I created 2 V2 addons, one with TS and one without. Then I copied over the contents of the one with TS to the other one and created a PR of those changes: https://github.com/lukasnys/addon-v2-to-typescript/pull/1/files.

Might be a starting point to getting it working? Though @NullVoxPopuli if you know of a list of commands to setup TS in a V2 addon more easily that would be perfect

NullVoxPopuli · 2024-06-27T10:58:30Z

I think if the typescript flag exist in the ember-cli-update.json, ember-cli-update will tell you what to add? Haven't tried, but just an idea.

Otherwise, the needed changes are in

babel.config
tsconfig
rollup.config
each runtime file (imported extensions change
template-registry.ts
package.json

charlesfries · 2024-07-02T20:32:36Z

Pushed a WIP TypeScript installation. This is the issue I'm hitting now:

RollupError: Could not resolve "../utils/as-array" from "src/helpers/chunk.ts"

Tried adding utils/**/*.js to the Rollup appReexports to no avail

NullVoxPopuli · 2024-07-02T20:38:21Z

in a v2 addon, you need to include the file extensions on the imports, so ../utils/as-array.ts

charlesfries · 2024-07-02T21:10:28Z

Thanks for the tip. It now seems to build correctly.

I'm now only seeing Cannot find module 'rsvp' or its corresponding type declarations.. I tried installing @types/rsvp in the ember-composable-helpers app but that doesn't seem to fix it. test-app already includes that types package--is there anywhere else I need to install that to fix that error? Never mind it's working now

NullVoxPopuli · 2024-07-02T22:35:36Z

ember-composable-helpers/src/-private/closure-action.ts

@@ -1,5 +1,6 @@
 import Ember from 'ember';


This is going to be problematic for Ember v7 😅

NullVoxPopuli · 2024-07-02T22:38:30Z

ember-composable-helpers/src/index.ts

I don't think we should introduce this file yet -- we can't use any of these helpers in JS because they still are wrapped with helper

(to use, we require invokeHelper, which is verbose to use)

FYI this file already existed, I just converted it to TS. Reverted regardless

package.json

test-app/package.json

NullVoxPopuli

some cleanup things to do <3

charlesfries · 2024-07-03T17:40:56Z

ember-composable-helpers/package.json

    "concurrently": "^8.2.1",
+    "ember-source": "~5.8.0",


Needed to install this + webpack peer to access built-in types

makes sense

charlesfries · 2024-07-03T17:42:24Z

ember-composable-helpers/src/helpers/map-by.ts


-export function mapBy([byPath, array]) {
+export function mapBy<T extends object>([byPath, array]: [keyof T, T[]]) {


get types are slightly different with built-in types--would it be preferable to use a type assertion on the get args instead of modifying the generic constraint like I've done here?

probably, ya

NullVoxPopuli · 2024-07-03T18:30:40Z

test-app/package.json

@@ -8,6 +8,7 @@
    "lint:css:fix": "concurrently \"npm:lint:css -- --fix\"",
    "lint:hbs": "ember-template-lint .",
    "lint:js": "eslint .",
+    "lint:types": "glint",


does this run in CI?

I don't actually see any linting going on in CI -- can you verify that linting and type checking is happening in the workflow files?

thanks!

I believe the lint scripts are actually broken on main (at least on my Windows comp) #19

I added pnpm run lint to the test app CI job, which should trigger a lint:types run

NullVoxPopuli · 2024-07-03T18:42:55Z

.github/workflows/ci.yml

@@ -23,6 +23,7 @@ jobs:
      - uses: actions/checkout@v4
      - uses: wyvox/action-setup-pnpm@v3
      - run: pnpm build
+      - run: pnpm run lint


can you put this in its own job above test-default?

and then add the lint command to package.json? 😅
https://github.com/NullVoxPopuli/ember-composable-helpers/pull/13/files#diff-b03f4acb30e04ceb12a40763ef649759b3f632df2357bcec14fab6dd29ebbfb4L5

charlesfries added 3 commits May 17, 2024 10:34

Add template registry

984ff87

Type helpers

df35f5a

Cleanup

6689a0f

Install TypeScript

f638e90

Add .ts extensions

141fdfc

charlesfries marked this pull request as ready for review July 2, 2024 21:19

NullVoxPopuli reviewed Jul 2, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

NullVoxPopuli reviewed Jul 2, 2024

View reviewed changes

test-app/package.json Outdated Show resolved Hide resolved

NullVoxPopuli reviewed Jul 2, 2024

View reviewed changes

test-app/package.json Outdated Show resolved Hide resolved

NullVoxPopuli requested changes Jul 2, 2024

View reviewed changes

charlesfries added 2 commits July 3, 2024 09:53

Cleanup

6794680

Use built in types

4c0923d

charlesfries commented Jul 3, 2024

View reviewed changes

Remove generic contraint

f43f371

NullVoxPopuli added the enhancement New feature or request label Jul 3, 2024

NullVoxPopuli reviewed Jul 3, 2024

View reviewed changes

Lint CI

d724526

NullVoxPopuli reviewed Jul 3, 2024

View reviewed changes

NullVoxPopuli added 2 commits July 6, 2024 17:17

Update package.json

6a4e191

Update package.json

ae98b0c

Update ci.yml

797c65c

NullVoxPopuli approved these changes Jul 6, 2024

View reviewed changes

NullVoxPopuli merged commit 802650c into NullVoxPopuli:main Jul 6, 2024
14 checks passed

github-actions bot mentioned this pull request Jul 6, 2024

Prepare Release #16

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install TypeScript, add template registry #13

Install TypeScript, add template registry #13

charlesfries commented May 17, 2024

lukasnys commented Jun 26, 2024

charlesfries commented Jun 26, 2024

lukasnys commented Jun 27, 2024

NullVoxPopuli commented Jun 27, 2024

charlesfries commented Jul 2, 2024

NullVoxPopuli commented Jul 2, 2024

charlesfries commented Jul 2, 2024 •

edited

Loading

NullVoxPopuli Jul 2, 2024

NullVoxPopuli Jul 2, 2024

charlesfries Jul 3, 2024

NullVoxPopuli left a comment

charlesfries Jul 3, 2024

NullVoxPopuli Jul 3, 2024

charlesfries Jul 3, 2024

NullVoxPopuli Jul 3, 2024

NullVoxPopuli Jul 3, 2024

NullVoxPopuli Jul 3, 2024

charlesfries Jul 3, 2024

NullVoxPopuli Jul 3, 2024


		export function mapBy([byPath, array]) {
		export function mapBy<T extends object>([byPath, array]: [keyof T, T[]]) {

Install TypeScript, add template registry #13

Install TypeScript, add template registry #13

Conversation

charlesfries commented May 17, 2024

lukasnys commented Jun 26, 2024

charlesfries commented Jun 26, 2024

lukasnys commented Jun 27, 2024

NullVoxPopuli commented Jun 27, 2024

charlesfries commented Jul 2, 2024

NullVoxPopuli commented Jul 2, 2024

charlesfries commented Jul 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NullVoxPopuli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charlesfries commented Jul 2, 2024 •

edited

Loading