Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: findBy return type #38

Closed
wants to merge 2 commits into from
Closed

fix: findBy return type #38

wants to merge 2 commits into from

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Jan 18, 2025 •
edited
Loading

currently return types is inferred as never[] | T | undefined which confuses glint and hard to bypass. Perhaps more appropriate is to just enforce T | undefined

@aklkv
Copy link
Contributor Author

aklkv commented Jan 18, 2025

nvm, I think I was on older version

@aklkv aklkv closed this Jan 18, 2025
@aklkv aklkv deleted the fix/find-by branch January 23, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aklkv