Make "pick" helper types less restrictive #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our codebase we frequently use the pick helper with objects that aren't Events (although that is one of the more common use cases). For example we have generic components that fire an action with an object, and we only want one property from the object to be passed up the action chain to more specific components. e.g.:
This attempts to relax the typing on the pick helper so it will accept either an object (or rather
Record<string, unknown>
) OR an Event.