Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: queue signature #44

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Feb 24, 2025

currently queue helper yield following signature:

export declare function queue(actions?: (() => void)[]): (...args: unknown[]) => unknown;
declare const _default: import("@ember/component/helper").FunctionBasedHelper<{
    Args: {
        Positional: unknown[];
        Named: object;
    };
    Return: unknown;
}>;
export default _default;

in situations where queue helper is invoked from on modifier and Return: unknown; results in an error:

Argument of type 'unknown' is not assignable to parameter of type '(event: MouseEvent) => void'.

Perhaps we need to update helper to yield signature like this:

export declare function queue(positional?: unknown[]): (...args: unknown[]) => unknown;
declare const _default: import("@ember/component/helper").FunctionBasedHelper<{
    Args: {
        Positional: unknown[];
        Named: object;
    };
    Return: (...args: unknown[]) => unknown;
}>;
export default _default;

@aklkv aklkv changed the title fix: queue signature fix: queue signature Feb 24, 2025
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Feb 24, 2025
@NullVoxPopuli NullVoxPopuli merged commit 6415108 into NullVoxPopuli:main Feb 24, 2025
11 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants