Add option to filter sessions by Host ID #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not sure if adding this makes a lot of sense. Personally I don't see the use-case of searching via host user ID since at best it's the username with a U- prefix and at worst it's gibberish. |
|
Maybe so, I mainly added as an option as it was another of the fields you can search and filter by as part of that api. |
|
Would this not make more sense as a feature of the host name field? i.e. call it Session Host and swap between interrogating the API about displaynames and usernames based on if the string starts with a |
|
I'll move it to be part of the Host name field so providing either will work there just based on starting with a "U-". That makes sense and provides the functionality without a separate element. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.