Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate reusable parameters and reusable objects. #182

Merged
merged 6 commits into from
May 17, 2024

Conversation

frankkilcommins
Copy link
Collaborator

@frankkilcommins frankkilcommins commented Apr 25, 2024

Simplified the referencing capabilities by consolidating Reusable Parameter Object into Reusable Object. This now means that there are two referencing mechanisms supported by the Workflows Specification:

  • JSON Schema references using $ref keyword. This can only be used for JSON Schema - e.g. Inputs defined in components
  • non JSON Schema referencing using the Resuable Object reference expression - e.g. all other component objects

closes #181

@frankkilcommins frankkilcommins added enhancement New feature or request implementor-draft In scope for first version labels Apr 25, 2024
Copy link
Collaborator

@kevinduffey kevinduffey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment but otherwise LGTM. Approving.. not sure you need to fix or if the wording is as it should be.

@frankkilcommins frankkilcommins requested a review from ndenny May 9, 2024 15:27
@frankkilcommins frankkilcommins merged commit cd256ae into main May 17, 2024
2 checks passed
@frankkilcommins frankkilcommins deleted the consolidate-reusable-objects branch July 31, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implementor-draft In scope for first version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 ways to reference reusable components
4 participants