Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS tweaks #21

Merged
merged 9 commits into from
May 23, 2019
Merged

CSS tweaks #21

merged 9 commits into from
May 23, 2019

Conversation

yochannah
Copy link
Member

okay - I think the CSS tweakage will be an ongoing work for now. This PR addresses:

Plenty more needs to be done but I think this is a respectable chunk. The changes are relatively low-risk and should be safe to deploy to prod I think (famous last words, I know) - they're largely font sizes, with some padding and margins, and one html class change. HUGE thanks to @peterjc and @heuermh for the visual feedback to get here.

Example collaborationfest page, before:

image

after:
image

@yochannah
Copy link
Member Author

This also fixes #16

@heuermh
Copy link
Member

heuermh commented May 22, 2019

Looks pretty good to me!

On the CoFest page I last tried bumping the headings up to H1/H2 from what they had been before (H3/H4 probably), so with this new CSS they could go back down if they are too big relative to the paragraph text size.

@nlharris
Copy link
Member

That looks much better--thank you!! We'll need to check all the pages after you make the change, because some layout stuff, picture sizes, etc. may need adjusting.

@peterjc
Copy link
Member

peterjc commented May 23, 2019

I agree, based on the screenshots this is a worthy improvement. The risk assessment seems fine too - let’s merge it?

@peterjc peterjc merged commit 1b056b1 into OBF:master May 23, 2019
@peterjc
Copy link
Member

peterjc commented May 23, 2019

The current README.md description is not clear to me, but I gather some (manual?) deployment step is required after the git merge?

@peterjc
Copy link
Member

peterjc commented May 23, 2019

Documenting deployment logged as #23.

@yochannah yochannah deleted the css-tweaks branch June 4, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants