Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_move_cancel_confirm: Migration to 18.0 #1851

Merged

Conversation

TheerayutEncoder
Copy link
Member

@JordiBForgeFlow
Copy link
Member

@TheerayutEncoder The dependency has been merged. Can you rebase?

@TheerayutEncoder TheerayutEncoder force-pushed the 18.0-mig-account_move_cancel_confirm branch from 8b165a8 to a414631 Compare February 25, 2025 18:44
@JordiBForgeFlow
Copy link
Member

@TheerayutEncoder Looking at https://github.com/OCA/account-invoicing/actions/runs/13528511272/job/37804915561?pr=1851#step:8:137, it seems that the tests needs to be adjusted, because the payment.state field is 'canceled' and not 'cancel'.

@TheerayutEncoder
Copy link
Member Author

Got it.
Thanks @JordiBForgeFlow

@JordiBForgeFlow
Copy link
Member

@JordiMForgeFlow can you review as well?

Copy link

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + functional

@JordiBForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1851-by-JordiBForgeFlow-bump-nobump, awaiting test results.

@JordiBForgeFlow
Copy link
Member

/ocabot migration account_move_cancel_confirm

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 26, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 26, 2025
16 tasks
@OCA-git-bot OCA-git-bot merged commit b4c2411 into OCA:18.0 Feb 26, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 71feedf. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants