[16.0][ADD] l10n_be_cooperator_portal_national_number

[carmenbianca]

Add a way for users to change their national number

Depends on #133, #134, #136

Internal task: https://gestion.coopiteasy.be/web#view_type=form&model=project.task&id=12581&active_id=12581&menu_id=

[carmenbianca]

Tagging two things. One is a definite must-fix before merging.

[victor-champonnois]

I found one issue, in the account details form, if I leave the national number empty, I cannot validate because I have an error "The national number is not valid.". This should not happen, I should be able to leave it empty (it's not a required field, at least not on the partner)

[carmenbianca]

@victor-champonnois Fixed your bug + module should now respect company-wide setting on whether national numbers are required.

This may mean that partners who previously had no national number (for unknown reasons) can now no longer change any other fields unless they now also add a national number.

[huguesdk]

thanks for this important feature!

there is some refactoring needed.

please separate the new module code from the refactoring is a separate pull requests (on top of each other). this would allow ocabot to correctly increment the version numbers:

• l10n_be_cooperator_national_number: minor
• l10n_be_cooperator_website_national_number: patch
• l10n_be_cooperator_portal_national_number: nobump

[carmenbianca]

added all improvements in fixups @huguesdk

please review again, and then i'll rebase + open more PRs

[victor-champonnois]

thanks for the fix !

[huguesdk]

thanks for the changes! almost there!

[huguesdk]

almost there!

[carmenbianca]

taking liberty to merge after intense reviews

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-131-by-carmenbianca-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at d17d05a. Thanks a lot for contributing to OCA. ❤️