[16.0][MIG] l10n_be_cooperator_portal #93

carmenbianca · 2023-10-06T13:24:40Z

Internal task: https://gestion.coopiteasy.be/web#id=10788&action=479&model=project.task&view_type=form&menu_id=536

Add the list of tax shelter certificate in the website portal. There is some issue with the access right. This must be fixed later. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Fix access right to the subscription and the share certificate. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

When using sudo, it should be done explicitly at each query. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Name the Tax Shelter Certificate correctly. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Remove wrong contributors. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Currently translated at 100.0% (9 of 9 strings) Translation: cooperative-14.0/cooperative-14.0-l10n_be_cooperator_portal Translate-URL: https://translation.odoo-community.org/projects/cooperative-14-0/cooperative-14-0-l10n_be_cooperator_portal/it/ Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

huguesdk · 2023-12-04T13:42:14Z

/ocabot migration l10n_be_cooperator_portal

huguesdk

this module works correctly on its own, but in its current state, it doesn’t cooperate correctly with cooperator_portal. please also look at the changes that were made to cooperator_portal while porting it to 16.0 (#91) and adapt the code accordingly.

l10n_be_cooperator_portal/controllers/main.py

huguesdk · 2023-12-04T15:24:14Z

l10n_be_cooperator_portal/controllers/main.py

@@ -12,15 +12,18 @@


 class PortalTaxShelter(CustomerPortal):


this should extend CooperatorPortal from the cooperator_portal module (which should be added to the dependencies), otherwise it removes its features.

l10n_be_cooperator_portal/__manifest__.py

huguesdk · 2023-12-04T15:33:48Z

@carmenbianca my bad: i thought that cooperator_portal was installed on the database where i tested the changes. it wasn’t. with it installed, the features of both seems to work well, so it seems that depending on it is not needed. the other comments are still valid, though.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

* follow the changes in PortalAccount in odoo 16 (from which it is derived). * simplify by removing the useless pager.

add buttons in the list of tax shelter certificates to allow to print them directly without needing to open the page that only contains those buttons.

use "tax_shelter_certificate" naming everywhere (instead of a mix of "taxshelter", "tax_shelter" and "taxshelter_certificate").

fix copyright statements: add missing ones and use the same format everywhere.

huguesdk · 2024-01-24T13:34:22Z

i’ve added some commits to clean up and fix some things. i also added the buttons to print the certificates in the list to allow to directly print them from there (instead of needing to open the page that only contains those buttons).

@carmenbianca @robinkeunen what do you think?

robinkeunen

A few non-blocking comments, thank you very much for these cleanup and improvements.

l10n_be_cooperator_portal/controllers/main.py

* use a common template for certificate print buttons. * rename "query_string" query string parameter to "certificate_type".

l10n_be_cooperator_portal/controllers/main.py

@@ -56,7 +59,7 @@ def portal_my_tax_shelter_certificates(
        * Tax Shelter Certificates
        * Shares Certifcates
        """
-        values = self._prepare_portal_layout_values()
+        values = self._prepare_home_portal_values("tax_shelter_count")


l10n_be_cooperator_portal/controllers/main.py

robinkeunen

LGTM, thanks for the fixes

huguesdk · 2024-02-02T08:10:26Z

/ocabot merge nobump

OCA-git-bot · 2024-02-02T08:10:46Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-93-by-huguesdk-bump-nobump, awaiting test results.

OCA-git-bot · 2024-02-02T08:19:22Z

Congratulations, your PR was merged at 56e1e74. Thanks a lot for contributing to OCA. ❤️

remytms and others added 30 commits October 2, 2023 16:54

[ADD] emc_w_taxshelter: Tax Shelter Certificate

520a6b1

Add the list of tax shelter certificate in the website portal. There is some issue with the access right. This must be fixed later. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_w_taxshelter: Access right issue

78735c9

Fix access right to the subscription and the share certificate. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_w_taxshelter: PDF download issue

c3b0c1e

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_w_taxshelter: Order of certificates

e49c58a

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_w_taxshelter: Old link for certificates

6239723

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_w_taxshelter: Use sudo explicitly

13fce3e

When using sudo, it should be done explicitly at each query. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_w_taxshelter: Correctly name certificate

be3f4dd

Name the Tax Shelter Certificate correctly. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_w_taxshelter: Contributors

d25d074

Remove wrong contributors. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[PEP8] pep8 code style refactoring

cb7cc1f

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[PEP8] fix pep8

010e2f0

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[MIG] migrate to v12 still wip

912ce99

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

Pypi setup

6ed62cb

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[ADD] module readmes

70f7790

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[REF] OCA pre-commit compliance

7ed8b48

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

automatic fixes

2d9c307

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[REF] pretty xml

8fdc8b7

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[MIG] emc_website_taxshelter: adaptation to 12.0

b02cf4e

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[IMP] emc_website_taxshelter: black formatter

b687f26

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[IMP] emc_website_taxshelter: readme

4bbbf19

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[IMP] emc_taxshelter_report,emc_website_taxshelter: pre-commit

c10f418

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_w_taxshelter: Typo

bd16ccf

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

make travis green again

ab5e6f8

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_tax_shelter: exclude line from wrong black formatting

1c04c3a

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[REF] pre-commit semanticless fixes

4beb9ef

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] Adjust website URLs in all manifest files

3f18a28

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[REF] pre-commit semanticless fixes

79f43bf

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] emc_api: create and update requests based on _external_api_id

ce49a8a

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] Run pre-commit on all files

8edd070

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[UPD] Update all .pot files

b2a47f5

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[FIX] easy_my_coop_website_taxshelter: Rename dependency

4143bca

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be> Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

mymage and others added 3 commits October 2, 2023 16:54

Added translation using Weblate (Italian)

cbd42d9

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[MIG] l10n_be_cooperator_portal: Migration to 15.0

b6b2eea

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

OCA-git-bot added this to the 16.0 milestone Dec 4, 2023

OCA-git-bot mentioned this pull request Dec 4, 2023

Migration to version 16.0 #87

Closed

7 tasks

huguesdk requested changes Dec 4, 2023

View reviewed changes

carmenbianca and others added 8 commits January 24, 2024 11:10

[MIG] l10n_be_cooperator_portal: Migration to 16.0

e162489

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[IMP] adapt to changes in odoo 16 and simplify

8e91473

* follow the changes in PortalAccount in odoo 16 (from which it is derived). * simplify by removing the useless pager.

[FIX] list only validated certificates

2af4f4b

[IMP] allow to print certificates from the list

892d4ad

add buttons in the list of tax shelter certificates to allow to print them directly without needing to open the page that only contains those buttons.

[REF] make naming more uniform

3d7528e

use "tax_shelter_certificate" naming everywhere (instead of a mix of "taxshelter", "tax_shelter" and "taxshelter_certificate").

[FIX] fix title of portal pages

a32a90f

[MOV] rename main.py to portal.py

ab52356

[IMP] adjust copyright statements

1c9dbe2

fix copyright statements: add missing ones and use the same format everywhere.

huguesdk force-pushed the 16.0-mig-l10n_be_cooperator_portal branch from 39be5da to 1c9dbe2 Compare January 24, 2024 13:32

robinkeunen approved these changes Jan 24, 2024

View reviewed changes

[IMP] improve portal templates

afb2ae1

* use a common template for certificate print buttons. * rename "query_string" query string parameter to "certificate_type".

huguesdk reviewed Jan 29, 2024

View reviewed changes

huguesdk requested a review from robinkeunen January 29, 2024 14:48

robinkeunen approved these changes Feb 1, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Feb 2, 2024

OCA-git-bot merged commit 7b8889d into OCA:16.0 Feb 2, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] l10n_be_cooperator_portal #93

[16.0][MIG] l10n_be_cooperator_portal #93

carmenbianca commented Oct 6, 2023

huguesdk commented Dec 4, 2023

huguesdk left a comment

huguesdk Dec 4, 2023

huguesdk commented Dec 4, 2023

huguesdk commented Jan 24, 2024

robinkeunen left a comment

This comment was marked as outdated.

robinkeunen left a comment

huguesdk commented Feb 2, 2024

OCA-git-bot commented Feb 2, 2024

OCA-git-bot commented Feb 2, 2024

[16.0][MIG] l10n_be_cooperator_portal #93

[16.0][MIG] l10n_be_cooperator_portal #93

Conversation

carmenbianca commented Oct 6, 2023

huguesdk commented Dec 4, 2023

huguesdk left a comment

Choose a reason for hiding this comment

huguesdk Dec 4, 2023

Choose a reason for hiding this comment

huguesdk commented Dec 4, 2023

huguesdk commented Jan 24, 2024

robinkeunen left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

robinkeunen left a comment

Choose a reason for hiding this comment

huguesdk commented Feb 2, 2024

OCA-git-bot commented Feb 2, 2024

OCA-git-bot commented Feb 2, 2024