Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [FIX] l10n_it_account_stamp: messaggio errato dopo applicazione bollo + reimposta a bozza modifica l'addebito del bollo #4529

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[16.0] [FIX] l10n_it_account_stamp: messaggio errato dopo applicazione bollo + reimposta a bozza modifica l'addebito del bollo #4529

wants to merge 2 commits into from
+59 −37

Conversation

primes2h
Copy link
Contributor

@primes2h primes2h commented Jan 15, 2025 •
edited
Loading

Risolve #4528 per 16.0.

Vedi anche #4414 (comment) e relativa review della PR.

@primes2h primes2h mentioned this pull request Jan 15, 2025
Open
3 tasks
@primes2h primes2h force-pushed the 16.0-FIX-account_tax_stamp_behaviour branch 5 times, most recently from e75bc23 to 5a78dff Compare January 16, 2025 08:24
MaurizioPellegrinet
MaurizioPellegrinet approved these changes Jan 16, 2025
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale: OK

@francesco-ooops francesco-ooops linked an issue Jan 17, 2025 that may be closed by this pull request
l10n_it_account_stamp: messaggio errato dopo applicazione bollo + reimposta a bozza modifica l'addebito del bollo #4528
Open
3 tasks
TheMule71
TheMule71 requested changes Jan 17, 2025
View reviewed changes
l10n_it_account_stamp/models/account_move.py Outdated
@@ -97,7 +96,6 @@ def add_tax_stamp_line(self):
inv.write({"invoice_line_ids": [(0, 0, invoice_line_vals)]})

def is_tax_stamp_line_present(self):
self.ensure_one()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perché rimuovere ensure_one()?
Il test ha senso per più fatture? Ossia serve sapere che tra N fatture almeno una abbia una riga che sia un bollo?

Se è una cosa che ha senso sapere fattura per fattura (a senso mi pare così), allora l'ensure_one ci va e se scatena un errore il problema è nel chiamante...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perché rimuovere ensure_one()?

In realtà era solo un revert alla situazione precedente, era stato aggiunto dalla PR #3802.

Se è una cosa che ha senso sapere fattura per fattura (a senso mi pare così), allora l'ensure_one ci va e se scatena un errore il problema è nel chiamante...

Attualmente nel codice viene sempre passata una singola fattura a is_tax_stamp_line_present(), però ha senso che ci sia il controllo. Riaggiunto.

@primes2h primes2h force-pushed the 16.0-FIX-account_tax_stamp_behaviour branch from 5a78dff to 4fd4a38 Compare January 19, 2025 16:26
@primes2h primes2h requested a review from TheMule71 January 19, 2025 16:27
@primes2h primes2h force-pushed the 16.0-FIX-account_tax_stamp_behaviour branch from 4fd4a38 to 0bc6e43 Compare January 20, 2025 13:53
@primes2h primes2h added the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Jan 20, 2025
@primes2h primes2h marked this pull request as draft January 21, 2025 11:16
@primes2h primes2h force-pushed the 16.0-FIX-account_tax_stamp_behaviour branch 2 times, most recently from e3548c4 to b2e994a Compare January 21, 2025 12:10
@primes2h primes2h marked this pull request as ready for review January 21, 2025 12:13
@primes2h primes2h force-pushed the 16.0-FIX-account_tax_stamp_behaviour branch from b2e994a to 0def33e Compare January 22, 2025 10:09
@primes2h primes2h force-pushed the 16.0-FIX-account_tax_stamp_behaviour branch from 0def33e to 763826f Compare February 3, 2025 22:24
@primes2h primes2h mentioned this pull request Feb 6, 2025
Open
sergiocorato
sergiocorato reviewed Feb 6, 2025
View reviewed changes
l10n_it_account_stamp/migrations/16.0.1.2.0/post-migration.py Outdated
Comment on lines 15 to 16
FROM product_template pt
WHERE aml.product_id = pt.id AND aml.is_stamp_line = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM product_template pt
WHERE aml.product_id = pt.id AND aml.is_stamp_line = True
WHERE aml.product_id IS NOT NULL AND aml.is_stamp_line = True

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fatto, grazie.

sergiocorato
sergiocorato requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vedi proposta su migrazione

@primes2h primes2h force-pushed the 16.0-FIX-account_tax_stamp_behaviour branch from 763826f to 1d0f01f Compare February 7, 2025 09:19
@primes2h primes2h requested a review from sergiocorato February 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMule71 TheMule71 Awaiting requested review from TheMule71

@MaurizioPellegrinet MaurizioPellegrinet Awaiting requested review from MaurizioPellegrinet

@sergiocorato sergiocorato Awaiting requested review from sergiocorato

Assignees
No one assigned
Labels
16.0 hotfix no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
No milestone
4 participants
@primes2h @TheMule71 @sergiocorato @MaurizioPellegrinet