Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] ebill_postfinance_stock #738

Merged
merged 8 commits into from
Jan 28, 2025
Merged

[17.0][MIG] ebill_postfinance_stock #738

merged 8 commits into from
Jan 28, 2025

Conversation

TDu
Copy link
Member

@TDu TDu commented Sep 20, 2024

No description provided.

@TDu TDu force-pushed the 17.0-mig-ebill_postfinance_stock branch from d955f1c to 7802913 Compare September 20, 2024 11:56
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 19, 2025
@ecino
Copy link

ecino commented Jan 20, 2025

What's the status of this? It looks good for to me, but I'm unsure about the unreleased dependencies failing.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 26, 2025
TDu and others added 6 commits January 28, 2025 13:24
@TDu
Add ebill_postfinance_stock
8d220b1 
Remove the dependency on stock in the `ebill_postfinance` module.
And add a new module `ebill_postfinance_stock` that will integrate
in the xml invoice informations related to the deliveries.

This is for Odoo implementation that sell only services and have no
stock to manage. And do not use the `stock` module.
@oca-travis @TDu
[UPD] Update ebill_postfinance_stock.pot
838020d
@OCA-git-bot @TDu
[BOT] post-merge updates
e3816eb
@TDu
[IMP] ebill_postfinance_stock: black, isort, prettier
13bdac2
@TDu
ebill_postfinance_stock: migrate to v16
e7766ff
@TDu
[UPD] Update ebill_postfinance_stock.pot
d4b84cb
@TDu TDu force-pushed the 17.0-mig-ebill_postfinance_stock branch from 7802913 to 7c41cfd Compare January 28, 2025 12:38
@TDu TDu force-pushed the 17.0-mig-ebill_postfinance_stock branch from 7c41cfd to 8a4c9b0 Compare January 28, 2025 12:59
@TDu
Copy link
Member Author

TDu commented Jan 28, 2025

@ecino All dependencies are merged, could you review, thanks

@TDu
Copy link
Member Author

TDu commented Jan 28, 2025

/ocabot migration ebill_postfinance_stock

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 28, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 28, 2025
Open
3 tasks
ecino
ecino approved these changes Jan 28, 2025
View reviewed changes
Copy link

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do functional testing, but the code looks good to me.

simahawk
simahawk reviewed Jan 28, 2025
View reviewed changes
ebill_postfinance_stock/tests/examples/invoice_qr_yb.xml
@@ -0,0 +1,192 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI if you want to avoid having linters to run here you should rename the folder to samples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thanks.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@TDu
Copy link
Member Author

TDu commented Jan 28, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-738-by-TDu-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8d3d6f6. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 27a3897 into OCA:17.0 Jan 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@ecino ecino ecino approved these changes

@henrybackman henrybackman henrybackman approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@TDu @ecino @OCA-git-bot @simahawk @henrybackman @oca-travis