Skip to content

Commit

Permalink
[FIX] operating_unit: rule operating_unit user has no group
Browse files Browse the repository at this point in the history
Fixes warning in logs:
```
odoo.addons.base.models.ir_model: Rule operating_unit user has no group, this is a deprecated feature. Every access-granting rule should specify a group.
```
  • Loading branch information
vvrossem committed Jan 28, 2025
1 parent 1d47c77 commit 6fe549d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
2 changes: 1 addition & 1 deletion operating_unit/security/ir.model.access.csv
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
access_account_operating_unit_erp_manager,operating.unit erp.manager,model_operating_unit,group_manager_operating_unit,1,1,1,1
access_account_operating_unit_user,operating_unit user,model_operating_unit,,1,0,0,0
access_account_operating_unit_user,operating_unit user,model_operating_unit,group_user_operating_unit,1,0,0,0
9 changes: 7 additions & 2 deletions operating_unit/security/operating_unit_security.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,20 @@
<field name="name">Multiple Operating Unit</field>
<field name="category_id" ref="module_operating_units" />
</record>
<record id="group_manager_operating_unit" model="res.groups">
<field name="name">Manager of Operating Units</field>
<record id="group_user_operating_unit" model="res.groups">
<field name="name">User of Operating Units</field>
<field name="implied_ids" eval="[(4, ref('group_multi_operating_unit'))]" />
<field
name="users"
eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"
/>
<field name="category_id" ref="module_operating_units" />
</record>
<record id="group_manager_operating_unit" model="res.groups">
<field name="name">Manager of Operating Units</field>
<field name="implied_ids" eval="[(4, ref('group_user_operating_unit'))]" />
<field name="category_id" ref="module_operating_units" />
</record>
<record id="operating_unit_comp_rule" model="ir.rule">
<field name="name">Operating Unit Entry</field>
<field name="model_id" ref="model_operating_unit" />
Expand Down
4 changes: 3 additions & 1 deletion operating_unit/tests/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def setUpClass(cls):
tracking_disable=True, no_reset_password=True
)
# Groups
cls.grp_ou_usr = cls.env.ref("operating_unit.group_user_operating_unit")
cls.grp_ou_mngr = cls.env.ref("operating_unit.group_manager_operating_unit")
cls.grp_ou_multi = cls.env.ref("operating_unit.group_multi_operating_unit")
# Company
Expand All @@ -27,7 +28,8 @@ def setUpClass(cls):
# Create User 1 with Main OU
cls.user1 = cls._create_user("user_1", cls.grp_ou_mngr, cls.company, cls.ou1)
# Create User 2 with B2C OU
cls.user2 = cls._create_user("user_2", cls.grp_ou_multi, cls.company, cls.b2c)
cls.user2 = cls._create_user("user_2", cls.grp_ou_usr, cls.company, cls.b2c)
cls.user2.write({"groups_id": [(4, cls.grp_ou_multi.id)]})
# Partner
cls.partner1 = cls.env.ref("base.res_partner_1")

Expand Down

0 comments on commit 6fe549d

Please sign in to comment.