Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] operating_unit_custom_header #646

Closed

Conversation

cjallais
Copy link

This PR adds a new module to add report header and footer by operating unit instead of company:

  • operating_unit_custom_header

@cjallais cjallais force-pushed the 14.0-add-operating_unit_custom_header branch from 1e315d0 to 355f134 Compare January 17, 2024 21:04
@AaronHForgeFlow
Copy link
Contributor

This is partially duplicating functionality of https://github.com/OCA/operating-unit/tree/14.0/report_qweb_operating_unit perhaps we can discuss if that module needs to be improved or be more generic

@cjallais
Copy link
Author

cjallais commented Jan 19, 2024 via email

@AaronHForgeFlow
Copy link
Contributor

@cjallais thats fine. I think this module is more flexible than the report_qweb_operating_unit module, which could be a reason for your module to take over from the other one. However, for current instances that uses report_qweb_operating_unit the transition to the new module seems not easy, as the default header and footer in the new module is different from the one in report_qweb_operating_unit module.

@cjallais
Copy link
Author

cjallais commented Jan 23, 2024 via email

@AaronHForgeFlow
Copy link
Contributor

report_qweb_operating_unit is also in v15. I think this module could take over in v16. For this version it is difficult, as long as no duplicate features should be allowed in OCA.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 30, 2024
@github-actions github-actions bot closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants