Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_operating_unit: do not show inter-OU balance journals as invoice lines #708

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

AaronHForgeFlow
Copy link
Contributor

Fixes: #617

FW port of: #705

Converted boolean in the field display_type. Same as Odoo did in here: odoo/odoo@d8d47f9

Also added the operating unit column in the journal items list inside the journal entry form. That must be removed by mistake during the migration.

@ForgeFlow

@AaronHForgeFlow
Copy link
Contributor Author

@JordiMForgeFlow @MiquelRForgeFlow I would appreciate your reviews, as long you reviewed the original code

Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 26, 2025
@AaronHForgeFlow AaronHForgeFlow removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 27, 2025
@AaronHForgeFlow
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@AaronHForgeFlow The rebase process failed, because command git push --force ForgeFlow tmp-pr-708:16.0-fix-account_operating_unit-inter-ou-as-invoice-line failed with output:

remote: Permission to ForgeFlow/operating-unit.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/ForgeFlow/operating-unit/': The requested URL returned error: 403

@AaronHForgeFlow AaronHForgeFlow force-pushed the 16.0-fix-account_operating_unit-inter-ou-as-invoice-line branch from a69cb8a to d2a2cc6 Compare January 27, 2025 08:06
@AaronHForgeFlow
Copy link
Contributor Author

Even thought this appears not to be an issue in v16, I'd like to continue with the forward ports:

  • Makes sense to have another display type for these special journal items
  • Easy to migrate between versions

Reviews welcome!

@AaronHForgeFlow AaronHForgeFlow added the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Jan 27, 2025
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved no stale Use this label to prevent the automated stale action from closing this PR/Issue. ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

account_operating_unit: inter ou balance lines are displayed in the invoice
4 participants