[17.0][IMP] crm_partner_company_group: show company_group_id on list and form view #1949
Conversation
CRogos
force-pushed
the
17.0-imp-crm_partner_company_group
branch
from
3771189 to
2f92641
Compare
|
@nguyenminhchien would you be so kind and do the second review of this improvement? |
| > | ||
| <field | ||
| name="company_group_id" | ||
| readonly="1" |
There was a problem hiding this comment.
| readonly="1" |
It's readonly by default of related field
| > | ||
| <field | ||
| name="company_group_id" | ||
| readonly="1" |
CRogos
force-pushed
the
17.0-imp-crm_partner_company_group
branch
from
2f92641 to
560d48c
Compare
CRogos
force-pushed
the
17.0-imp-crm_partner_company_group
branch
from
560d48c to
f74e679
Compare
|
This PR has the |
|
@pedrobaeza I think this is ready for merge. Thank you. |
| expr="//group[@name='opportunity_partner']/field[@name='partner_id']" | ||
| position="after" | ||
| > | ||
| <field name="company_group_id" invisible="not company_group_id" /> |
There was a problem hiding this comment.
Why not letting to assign it if not set?
There was a problem hiding this comment.
The field is readonly and copied from the res.partner to crm.lead.
class CrmLead(models.Model):
_inherit = "crm.lead"
company_group_id = fields.Many2one(
related="partner_id.company_group_id", store=True
)
I agree that there a some interfaces, where you can change res.partner informations in the lead interface, but this is often not understood correctly by the users and they think they change something on this one lead, but they are actually change it on the linked contact for all leads.
There was a problem hiding this comment.
OK, understood. Yes, it's OK this way then.
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 405873c. Thanks a lot for contributing to OCA. ❤️ |
No description provided.