[17.0][MIG] product_configurator #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for onchange_custom_type and val_custome_field method
…or product attributes onchange and constraint methods
…se cfg_session_id
…rator_values and other code improvements
…for check weight_extra method
…d some changes for test-case
…for check weight_extra method and write test cases
…r product_config file
…alue_id and value_ids field
…tor_image_builder : add domain on value_id and value_ids and create a new field and add compute method.
…write test case for inverse method and check weight_extra method
…product_attribute file.
Nikul-OSI
force-pushed
the
17_mig_product_configurator
branch
2 times, most recently
from
696190f to
1857ed8
Compare
Nikul-OSI
force-pushed
the
17_mig_product_configurator
branch
2 times, most recently
from
185e5de to
4d439d3
Compare
Nikul-OSI
force-pushed
the
17_mig_product_configurator
branch
from
2d2fb35 to
ac945b4
Compare
|
@PCatinean @dreispt @dannyadair Can you please take a look? |
Nikul-OSI
changed the title
1 task
|
@Nikul-OSI Why the PATCH labels in the history commits, can you please remove them? |
dreispt
requested changes
Feb 22, 2024
| hooks: | ||
| - id: ruff | ||
| args: [--fix, --exit-non-zero-on-fix] | ||
| - id: ruff-format |
| @@ -183,16 +181,18 @@ def onchange_values(self): | |||
| def _check_default_values(self): | |||
| """default value should not be outside of the | |||
| values selected in attribute line""" | |||
| for line in self.filtered(lambda l: l.default_val): | |||
| for line in self.filtered(lambda line: line.default_val): | |||
There was a problem hiding this comment.
I'm pretty sure these changes were already in v16.
Can you check you brought over all commits there?
| @@ -685,7 +685,7 @@ def write(self, vals): | |||
| try: | |||
| self.validate_configuration(final=False) | |||
| except ValidationError as exc: | |||
| raise ValidationError(_("%s") % exc.name) from exc | |||
| raise ValidationError(_("{}".format(exc))) | |||
There was a problem hiding this comment.
Maybe raise ValidationError(_("{}").format(exc))?
Or even better, I can't see the point for this except, what if we remove it?
| ) | ||
| specs.update(ch_specs) | ||
|
|
||
| # TODO :- Commented a code and ths code already base in a odoo base modules. |
|
Superseded by #117 , that has the commit history fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.