Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] product_configurator: Migration to 16.0 #96

Closed
wants to merge 483 commits into from
Closed

[16.0][MIG] product_configurator: Migration to 16.0 #96

wants to merge 483 commits into from

Conversation

dannyadair
Copy link
Contributor

No description provided.

bizzappdev and others added 30 commits June 11, 2023 14:13
@bizzappdev @dannyadair
[IMP]add image for configured product using url and remove code for r…
47e648c 
…esize image
@dannyadair
[ADD][#T00494]product_configurator:write onchange method for attributes
9f2179d
@dannyadair
[ADD][#T00494]website_product_configurator:solved flake8 and pylintsc
f689cd1
@bizzappdev @dannyadair
[FIX]product_configurator : remove None from value_ids
f6300b7
@dannyadair
[ADD][#T00494]website_product_configurator:solved flake8 and pylints
da6e9d9
@bizzappdev @dannyadair
[FIX]fix flake8 error
21e0920
@bizzappdev @dannyadair
[FIX]fix pylint error
d02dc99
@bizzappdev @dannyadair
[FIX] fix pylint
86ae138
@bizzappdev @dannyadair
[FIX]product_configurator: fix - no step will open if session-config_…
449fb6f 
…step not in open step lines
@bizzappdev @dannyadair
[FIX]use list comprehansion instead of map()
b07daea
@PCatinean @dannyadair
Small cosmetic improvement
60c601c
@bizzappdev @dannyadair
[FIX] use UserError instead of Warning
edd67df
@bizzappdev @dannyadair
[FIX]fix flake8 and py-lint errors
676f2fb
@dannyadair
[IMP][#T00513]product_configurator:create test cases for onchange_cus…
25edcf5 
…tom_type and val_custome_field method
@dannyadair
[IMP][#T00513]product_configurator:change variable name
b477c4c
@dannyadair
[WIP][#T00513]product_configurator: write test case for product attri…
50b5091 
…butes onchange and constraint methods
@bizzappdev @dannyadair
[FIX]fix changes request during review
69db1b3
@bizzappdev @dannyadair
[FIX]remove parameter limit from search_session and use cfg_session_id
7cad20f
@dannyadair
[IMP][T-00511] website configuration image
d5afb56
@bizzappdev @dannyadair
[T-00513][ADD] product_Configurator_image_builder: write test-case
0f2e93e
@bizzappdev @dannyadair
[FIX]check values only if both exists
46be666
@bizzappdev @dannyadair
[FIX]fix attribute_value_line_ids in _prepare_configurator_values and…
ec426e0 
… other code improvements
@dannyadair
[WIP][#T00513]product_configurator: improve the code for check weight…
e53dd8b 
…_extra method
@bizzappdev @dannyadair
[T-00513][ADD] product_configurator_image_builder: add some changes f…
1c23a79 
…or test-case
@dannyadair
[WIP][#T00513]product_configurator: improve the code for check weight…
ca58c90 
…_extra method and write test cases
@bizzappdev @dannyadair
[FIX]add domain in record rules
23ff0fa
@dannyadair
[WIP][#T00513]product_configurator:write test case for product_config…
2131f8a 
… file
@bizzappdev @dannyadair
[FIX]fix record rules
2874bc7
@bizzappdev @dannyadair
[FIX]change module name to base from product_configurator
62588df
@bizzappdev @dannyadair
[FIX]remove extra parentheses
24e0b15
@dannyadair dannyadair changed the title [16.0][MIG] product_configurator: Migration to 16.0 DRAFT [16.0][MIG] product_configurator: Migration to 16.0 Jun 11, 2023
@dannyadair dannyadair changed the title DRAFT [16.0][MIG] product_configurator: Migration to 16.0 DRAFT: [16.0][MIG] product_configurator: Migration to 16.0 Jun 11, 2023
@dannyadair dannyadair force-pushed the 16.0-mig-product_configurator branch from cf455cf to 9bb42b9 Compare June 11, 2023 08:31
@dannyadair dannyadair changed the title DRAFT: [16.0][MIG] product_configurator: Migration to 16.0 [16.0][MIG] product_configurator: Migration to 16.0 Jun 11, 2023
This was referenced Jun 11, 2023
Merged
Closed
@dannyadair dannyadair force-pushed the 16.0-mig-product_configurator branch from c6d5471 to 8c20d4b Compare June 11, 2023 10:25
@pumppi
Copy link

pumppi commented Jun 23, 2023

Hi, I tested this with odoo 16. And found out that I got few errors when rendering custom views with OWL and issue was in

@property def _prefixes(self): """Return a dictionary with all dynamic field prefixes used to generate fields in the wizard. Any module extending this functionality should override this method to add all extra prefixes""" return { "field_prefix": "__attribute_", "custom_field_prefix": "__custom_", }

Changed field prefix and custom prefix to full underscore

@dannyadair dannyadair force-pushed the 16.0-mig-product_configurator branch from c212d3d to 1793374 Compare June 29, 2023 20:03
@dannyadair
Copy link
Contributor Author

Thanks @pumppi I've applied that change (also to all the tests).

AurelijaNorvaisaite added a commit to versada/product-configurator that referenced this pull request Oct 17, 2023
@AurelijaNorvaisaite
[ADD] product_configurator/_sale
0b66816 
https://hive.versada.eu/work_packages/20663/activity

Code is migrated from:
OCA#97
OCA#96
@AurelijaNorvaisaite AurelijaNorvaisaite mentioned this pull request Oct 17, 2023
Merged
AurelijaNorvaisaite added a commit to versada/product-configurator that referenced this pull request Oct 18, 2023
@AurelijaNorvaisaite
Merge pull request #1 from versada/mig-20663-product-configurator-avi
e27c704 
[ADD] product_configurator/_sale

https://hive.versada.eu/work_packages/20663/activity

Code is migrated from:
OCA#97 OCA#96
@matt454357
Copy link
Contributor

@PCatinean, @dreispt, @patrickrwilson,
Can this PR be merged?
I would like to contribute, but waiting on this PR.
Maybe there is still some issue? Not sure why the runboat/build has Pending status.

@dannyadair dannyadair force-pushed the 16.0-mig-product_configurator branch from 1793374 to 028f171 Compare November 22, 2023 22:14
@dannyadair
Copy link
Contributor Author

Corrected version number to 16.0.1.0.0

@dannyadair
Copy link
Contributor Author

I believe flake8 version should be bumped (latest 6.1.0, and bugbear 23.9.16) but that's outside the scope of this PR.
https://github.com/OCA/product-configurator/blob/16.0/.pre-commit-config.yaml#L122

@dannyadair
Copy link
Contributor Author

@PCatinean @jjscarafia @JordiBForgeFlow @rousseldenis I think all the precommits could be failing at the moment.
(https://oca.github.io/repo-maintainer-conf/teams.html#product-maintainers)

@dreispt dreispt mentioned this pull request Dec 9, 2023
Merged
@dannyadair
Copy link
Contributor Author

Superseded by #101

@dannyadair dannyadair closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.