pandas~2.0 #887
pandas~2.0 #887
Conversation
ubuntu-latest-python3.11-pandas@^1.3 test results 10 files + 10 10 suites +10 7m 53s ⏱️ + 7m 53s Results for commit d041eb6. ± Comparison against base commit ae5945d. ♻️ This comment has been updated with latest results. |
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Approved. As for the errors caused by pandas 2.1.0, I came across many of the same ones locally when working on dcat distribution and had to run poetry update, so I spent some time coming up with fixes. I ended up resolving the errors on my end, but that was only on that branch which already had changes to many other files. Here is the commit where I was working on the pyright issues which mostly match the ones you listed in #886: f0f707b
Let me know what you think, I don't know if my fixes are correct since I was working locally in a branch that already had many other changes in it, so I may have approached it with the perspective of "just get it working" instead of really looking at what changed in 2.1.0 and how to fix them according to that. On one file I ended up using a # type: ignore because I couldn't find any other way to fix the error with isna not being recognised. But maybe try them on your end and see if it helps with pyright at all.
SarahJohnsonONS
deleted the
Version-lock-pandas-2.0-in-main-push.yaml-and-release.yaml
branch
Version lock pandas~2.0 until #886 complete