Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate function #67

Merged
merged 13 commits into from
Jul 13, 2021
Merged

Validate function #67

merged 13 commits into from
Jul 13, 2021

Conversation

josepajay
Copy link
Contributor

@josepajay josepajay commented Jul 6, 2021 •
edited
Loading

This PR closes issue #57

@josepajay josepajay marked this pull request as ready for review July 7, 2021 15:05
@josepajay josepajay requested a review from roblinksdata July 7, 2021 15:05
roblinksdata
roblinksdata reviewed Jul 8, 2021
View reviewed changes
Copy link
Contributor

@roblinksdata roblinksdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good work again, with a few suggestions.

project/plugins.sbt Show resolved Hide resolved
src/main/scala/Main.scala Outdated Show resolved Hide resolved
src/main/scala/Main.scala Show resolved Hide resolved
src/main/scala/Main.scala Outdated Show resolved Hide resolved
src/main/scala/Table.scala Outdated Show resolved Hide resolved
src/main/scala/Validator.scala Outdated Show resolved Hide resolved
src/main/scala/Validator.scala Outdated Show resolved Hide resolved
src/main/scala/models/Dialect.scala Show resolved Hide resolved
src/main/scala/models/KeyWithContext.scala Show resolved Hide resolved
src/test/scala/ValidatorTest.scala Outdated Show resolved Hide resolved
@josepajay josepajay force-pushed the 57-validate-function branch from d415aff to 969d797 Compare July 12, 2021 09:54
@josepajay josepajay force-pushed the 57-validate-function branch from 1f2b9f9 to da90dd9 Compare July 13, 2021 13:09
@josepajay josepajay force-pushed the 57-validate-function branch from da90dd9 to 91cd1a8 Compare July 13, 2021 15:12
@josepajay josepajay merged commit faf13bf into master Jul 13, 2021
@roblinksdata roblinksdata deleted the 57-validate-function branch December 14, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblinksdata roblinksdata roblinksdata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josepajay @roblinksdata