Skip to content

Commit

Permalink
update from data-toggle to data-bs-toggle (#4115)
Browse files Browse the repository at this point in the history
update from data-toggle to data-bs-toggle to correct a few toggle
panels. Specifically the native VNC connection tab, but this also
fixes a tooltip or two.
  • Loading branch information
johrstrom authored Feb 5, 2025
1 parent acb6fa2 commit 8487757
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def connection_tabs(id, tabs)
content_tag(:ul, class: "nav nav-tabs") do
tabs.map { |t| t[:title] }.map.with_index do |title, idx|
content_tag(:li, class: "nav-item #{"active" if idx.zero?}") do
link_to title, "#c_#{id}_#{idx}", data: { toggle: "tab" }, aria: { selected: (true if idx.zero?) }, class: "nav-link #{"active" if idx.zero?}"
link_to title, "#c_#{id}_#{idx}", data: { 'bs-toggle': "tab" }, aria: { selected: (true if idx.zero?) }, class: "nav-link #{"active" if idx.zero?}"
end
end.join("\n").html_safe
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
class: %w[btn px-1 py-0 btn-outline-dark edit-saved-settings-button full-page-spinner],
title: title,
'aria-label': title,
data: { toggle: "tooltip", placement: "left" }
data: { 'bs-toggle': "tooltip", 'bs-placement': "left" }
) do
fa_icon('pen', classes: nil)
end
Expand All @@ -24,7 +24,7 @@
form_class: %w[d-inline],
title: title,
'aria-label': title,
data: { toggle: "tooltip", placement: "left" },
data: { 'bs-toggle': "tooltip", 'bs-placement': "left" },
params: params
) do
fa_icon('play', classes: nil)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ locals: {
class: %w[btn btn-danger full-page-spinner],
title: title,
'aria-label': title,
data: { confirm: t('dashboard.bc_saved_settings.delete_confirm'), toggle: "tooltip", placement: "left"}
data: { confirm: t('dashboard.bc_saved_settings.delete_confirm'), 'bs-toggle': "tooltip", 'bs-placement': "left"}
) do
"#{fa_icon('times-circle', classes: nil)} <span aria-hidden='true'>#{t('dashboard.delete')}</span>".html_safe
end
Expand Down

0 comments on commit 8487757

Please sign in to comment.