Move system-status percentage outside of status bar #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Nov 18, 2024
|
|
||
| <% if valid_percent?(current_status[:percent]) %> | ||
| <div class="progress"> | ||
| <div class="progress-bar" role="progressbar" style="width: <%= current_status[:percent] %>"><%= current_status[:percent] %> in use</div> | ||
| <div class="progress-bar" role="progressbar" style="width: <%= current_status[:percent] %>"></div> |
There was a problem hiding this comment.
Thanks. I was looking into this too. Can we also change this inline style to w-<%= current_status[:percent].to_i %> class? we have w-[1-100] css classes.
|
Thanks for looking into this. I spent just a bit too much time looking into |
|
If you think of something that works better I can definitely look into it more! From what I was able to find and try though, I couldn't find a way to make it "look right" and consistent for all percentages. |
|
Given what you have here, I'm not going to look into it anymore. I also couldn't get the text to be the right color on both the progress and the background. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3953
Moves the
N% in usemessage underneath the status bar instead of within in it.