Saved imported directory into lookup_file for shared projects #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Feb 28, 2025
apps/dashboard/app/models/project.rb
Outdated
Comment on lines
28
to
31
| manifest_path = Pathname("#{dir.to_s}/.ondemand/manifest.yml") | ||
| unless manifest_path.exist? | ||
| Rails.logger.warn("Imported directory is not a Open OnDemand project") | ||
| return false |
There was a problem hiding this comment.
Can we add some sort of class method helper that's like self.from_directory. I feel like that would clean some of this up. Let it return nil if it can't make a project out of the directory, and a real Project object if it can.
johrstrom
reviewed
Feb 28, 2025
apps/dashboard/app/models/project.rb
Outdated
Comment on lines
34
to
49
| contents = File.read(manifest_path) | ||
| raw_opts = YAML.safe_load(contents) | ||
| id = raw_opts["id"] | ||
| new_table = Project.lookup_table.merge(Hash[id, dir.to_s]) | ||
|
|
||
| @project = Project.find(id) | ||
| if @project.nil? | ||
| File.write(Project.lookup_file, new_table.to_yaml) | ||
| else | ||
| Rails.logger.info("Imported project #{dir} already exists in lookup file") | ||
| end | ||
| true | ||
| rescue StandardError => e | ||
| Rails.logger.warn("Cannot import project #{dir} to lookup file due to error #{e}") | ||
| false | ||
| end |
There was a problem hiding this comment.
When you instantiate a Project, if it's valid you can use the member function add_to_lookup like so:
project = Project.from_directory(dir)
project.nil? ? false : project.add_to_lookup(:import)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #4120
This is the second PR, to add the directory of shared project path into a user's own project lookup file.
First PR: #4178
Later, we will show the list of shared projects in import form based upon user's group-id.