Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker role to setup_dev_environment.yml #246

Closed
wants to merge 16 commits into from
Closed

Add docker role to setup_dev_environment.yml #246

wants to merge 16 commits into from

Conversation

HansRobo
Copy link
Contributor

This PR will resolve #238 and #245

@HansRobo HansRobo requested a review from swiftfile August 10, 2022 09:49
@HansRobo HansRobo self-assigned this Aug 10, 2022
@HansRobo HansRobo changed the title Add dcker role to setup_dev_environment.yml Add docker role to setup_dev_environment.yml Aug 10, 2022
@swiftfile
Copy link
Contributor

swiftfile commented Aug 13, 2022 •
edited
Loading

@HansRobo
Thanks for improving on my behalf!
By the way, Is this PR still a work in progress?
Of course, This PR will enhance this repo( #238 ). But, I think this PR does not resolve #245.
If you agree with my opinion, no problem. Please continue to improve 🙏

@hakuturu583
add tmate step
0bc3a62 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583
configure trigger
cdf868c 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583
change tmate position
8bd6de0 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583
add locales
e214205 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583
specify container
4c95daa 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583
remove sudo
efc6240 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583
use apt-get
c6c1fad 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583
add apt-get update step
c5be3a3 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583
install locale first
23131d0 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583
remove unused step
07b2d3c 
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@HansRobo
Copy link
Contributor Author

@swiftfile
Actually, the docker role is including sshpass installation.

@HansRobo
Copy link
Contributor Author

https://github.com/OUXT-Polaris/ouxt_automation/blob/master/ansible/roles/docker/tasks/main.yml#L19

@swiftfile
Copy link
Contributor

swiftfile commented Aug 13, 2022 •
edited
Loading

I wasn't careful enough...
@HansRobo Thanks for the kind explanation!
LGTM!

@HansRobo HansRobo closed this Jul 4, 2024
@hakuturu583 hakuturu583 deleted the add-docker-role-to-dev-env branch December 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiftfile swiftfile Awaiting requested review from swiftfile

Assignees

@HansRobo HansRobo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add installing docker and docker-compose to ansible roles
3 participants
@HansRobo @swiftfile @hakuturu583