cmd: don't bind debug endpoints by default #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate Prometheus from pprof/QBFT HTTP endpoint, and let user configure the listening address for them. Added the `--debug-addr` CLI argument, so that user can specify the IP/port combo that suite them better. If no `--debug-addr` is specified, don't bind debug endpoints.
|
|
Needs a corresponding PR here: https://github.com/ObolNetwork/obol-docs/blob/main/docs/charon/charon-cli-reference.md#the-run-subcommand |
pinebit
reviewed
Jan 22, 2024
| @@ -139,6 +139,7 @@ Usage: | |||
| Flags: | |||
| --beacon-node-endpoints strings Comma separated list of one or more beacon node endpoint URLs. | |||
| --builder-api Enables the builder api. Will only produce builder blocks. Builder API must also be enabled on the validator client. Beacon node must be connected to a builder-relay to access the builder network. | |||
| --debug-address string Listening address (ip and port) for the pprof and QBFT debug API. | |||
There was a problem hiding this comment.
Worth to mention it is disabled by default.
pinebit
approved these changes
Jan 22, 2024
|
ObolNetwork/obol-docs#299 docs PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2808 +/- ##
==========================================
- Coverage 53.29% 53.25% -0.05%
==========================================
Files 199 199
Lines 27680 27694 +14
==========================================
- Hits 14753 14748 -5
- Misses 11097 11118 +21
+ Partials 1830 1828 -2 ☔ View full report in Codecov by Sentry. |
gsora
added
the
merge when ready
gsora
added a commit
that referenced
this pull request
Jan 24, 2024
Same principle as #2808. Refactor the binding functions to be usable across multiple commands.
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
Same principle as #2808. Refactor the binding functions to be usable across multiple commands. category: refactor ticket: none
gsora
added a commit
that referenced
this pull request
Jan 24, 2024
Separate Prometheus from pprof/QBFT HTTP endpoint, and let user configure the listening address for them. Added the `--debug-address` CLI argument, so that user can specify the IP/port combo that suite them better. If no `--debug-address` is specified, don't bind debug endpoints. category: refactor ticket: none
gsora
added a commit
that referenced
this pull request
Jan 24, 2024
Same principle as #2808. Refactor the binding functions to be usable across multiple commands. category: refactor ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate Prometheus from pprof/QBFT HTTP endpoint, and let user configure the listening address for them.
Added the
--debug-addressCLI argument, so that user can specify the IP/port combo that suite them better.If no
--debug-addressis specified, don't bind debug endpoints.category: refactor
ticket: none