fix: adds proper handling for permissionless bold chains #45
Conversation
packages/assertion-monitor/index.ts
Outdated
| ) | ||
|
|
||
| // Check validation permissioning based on chain type | ||
| const validationPermissioningIssue = isBold |
There was a problem hiding this comment.
For BoLD you also have to check if the whitelist is disabled. It's normal to have a low baseStake if the chain is permissioned, but not normal if it's permissionless.
So the check should be something like validatorWhitelistIsDisabled && isBaseStakeBelowThreshold
| parentClient, | ||
| childChainInfo.ethBridge.rollup | ||
| ) | ||
| const isBaseStakeBelowThreshold = await fetchIsBaseStakeBelowThreshold( |
There was a problem hiding this comment.
I think this checks now both BoLD and classic chains. This is not really needed for classic chains, but if you want to have the complete information, then we should change the comment in fetchIsBaseStakeBelowThreshold, since it assumes it's a BoLD-enabled chain. Otherwise, restrict it only for BoLD chains.
| alerts.push(VALIDATOR_WHITELIST_DISABLED_ALERT) | ||
| } | ||
|
|
||
| if (isBaseStakeBelowThresholdOnBold) { |
There was a problem hiding this comment.
I think the same thing still happens here, since it's not checking if the validator whitelist is disabled AND the baseStake is below the threshold 😅
No description provided.