refactor: cleans up scripts folder #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglance
commented
Dec 17, 2024
| console.log('Removing previously generated ABIs.\n') | ||
| rmSync('./src/lib/abi/', { recursive: true }) | ||
| } | ||
| console.log('Removing previously generated ABIs.\n') |
There was a problem hiding this comment.
force: true doesn't need to check if it exists.
douglance
commented
Dec 17, 2024
| @@ -56,7 +56,7 @@ jobs: | |||
| - name: Lint sdk | |||
| run: | | |||
| yarn gen:abi | |||
| yarn build --reporter-options output=$TEST_PATH/sdk.xml | |||
| yarn build | |||
There was a problem hiding this comment.
this wasn't actually doing anything as far as I can tell. we don't need it.
it also fails using the inline commands, rather than the build script which was perhaps needed in the past but is unnecessary indirection now.
spsjvc
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testSetupto/testsfolder