Fix bezier ratio on spiral pre_calc #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredkhan
commented
Nov 13, 2024
| node.children[0].bezsy = -(0.3)*(tempsinpre)/thisratio1; | ||
| node.children[0].bezex = tempcos2; | ||
| node.children[0].bezey = tempsin2; | ||
| node.children[0].bezc1x = -0.3*(tempcospre)/thisratio1; |
There was a problem hiding this comment.
Notice how this number...
| node.children[1].bezsy = -(0.3)*(tempsinpre)/thisratio1; | ||
| node.children[1].bezex = tempcos2; | ||
| node.children[1].bezey = tempsin2; | ||
| node.children[1].bezc1x = -0.2*(tempcospre)/thisratio1; |
There was a problem hiding this comment.
...wasn't the same as this number
|
Nice, and thanks for doing the refactoring here! |
|
Good spot, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #894
Ok, I know it's a silly one, but I think it is a bit more pleasing, and by the looks of it this parameter value just got lost when ladderized newick files were introduced. I tidied that up so the two branches use the same bezier parameters.
Before:
After:
