-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recent places to search dropdown #902
Conversation
Works great! A few comments, all minor:
Wow, didn't know that either! |
Thanks for your comments @davidebbo! |
I just tried the changes, and it all feels good in real use, so I'd suggest taking them all. Thanks! |
Great. I'll just merge this then, and we can tweak later if necessary. Thanks so much @jaredkhan |
@jaredkhan one possible concern: once we turn that on in the main tree as well, are https://www.onezoom.org/life/ and https://www.onezoom.org/extinct/life/ going to end up sharing the same list? Or can it be smart enough to differentiate them in how they're stored (since they are kept across sessions)? |
Yeah good point, it certainly would share the same list at the moment. |
I think this is worth addressing. Presumably, it's as simple as using a key modifier in |
Adds a 'recent places' section to the search dropdown.
Only captures items that you have clicked in the search dropdown (not things that you have arrived at via URL or panned to in the viewer)
Has a 'Clear recents' button.
Still works with click and drag to common ancestor etc (didn't know this feature was there!)
I've added it to the homepage too.
Length is limited to 5 items.
Visiting the same item from a search result twice will reposition it in the list rather than duplicating it.
Items are stored in localStorage so that they survive a refresh.
Fixes #878