Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB-9426: Various improvements part 3 #96

Merged
merged 12 commits into from
May 10, 2024

Conversation

mihailradkov
Copy link
Contributor

@mihailradkov mihailradkov commented Apr 25, 2024

Java arguments updates

  • The javaArguments values are moved into another defaultJavaArguments to allow easier overriding with javaArguments
  • Removed configuration overrides from the default GDB_JAVA_OPTS: enable-context-index, entity-pool-implementation and health.max.query.time.seconds
  • Removed default.min.distinct.threshold from the default defaultJavaArguments values
  • Added -XX:-UseCompressedOops in the default Java arguments to allow allocating heap sizes larger than 32GBs when the max heap size is based on the -XX:MaxRAMPercentage Java option

Enriched the StatefulSet configurations

  • Added updateStrategy and proxy.updateStrategy for controlling the strategy when updating pods
  • Added podManagementPolicy and proxy.podManagementPolicy for configuring how the pods are created and scaled
  • Added automountServiceAccountToken with default value false effectively ejecting the service account token by default
  • Added schedulerName and proxy.schedulerName for overriding the default Kubernetes scheduler
  • Added dnsConfig, dnsPolicy, proxy.dnsConfig and proxy.dnsPolicy for customizing the DNS resolution if needed
  • Added proxy.initContainerSecurityContext and proxy.initContainerResources to avoid using the configurations from GraphDB
  • Ejected the default service account token in the proxy pods

Added capability for additional resources

  • Added extraContainers and proxy.extraContainers for inserting additional containers into the pods of GraphDB and the GraphDB proxy
  • Added extraObjects as a way to insert additional Kubernetes objects into the deployment

Added new service configurations

  • Updated the chart to require Kubernetes version 1.24+
  • Added service.externalTrafficPolicy and service.proxy.externalTrafficPolicy to override the policy to Local if needed
  • Added service.healthCheckNodePort and service.proxy.healthCheckNodePort to define a specific node port for LB health checks
  • Added service.loadBalancerClass and service.proxy.loadBalancerClass to select a specific load balancer implementation
  • Added service.loadBalancerSourceRanges and service.proxy.loadBalancerSourceRanges to restrict the external ingress traffic from the LB
  • Added service.externalIPs and service.proxy.externalIPs to use existing external IPs
  • Added service.extraPorts and service.proxy.extraPorts for exposing additional ports

Updated NOTES.txt

  • Added helper for printing warnings
  • Formatting

StatefulSets volume name updates

  • Renamed GraphDB storage PVC template name prefix to storage and server import folder to import
  • Renamed all proxy volumes to start with graphdb-proxy-

Extra labels and annotations for PVC templates

  • Added configurations for extra labels and annotations for all persistent volume claim templates: persistence, proxy.persistence and import.volumeMount

Added job configurations

  • Added jobs.backoffLimit for configuring the retry count for all jobs
  • Added jobs.ttlSecondsAfterFinished for configuring the time in seconds for all jobs before deleting finished pods
  • Added jobs.persistence.emptyDir configurations for the default temporary storage for all jobs

Updated the provisioning user

  • Moved provisioningUsername and provisioningPassword under security.provisioner
  • Added security.provisioner.existingSecret and security.provisioner.tokenKey to provide an existing authentication token
  • Small bash script cleaning

@mihailradkov mihailradkov marked this pull request as draft April 25, 2024 17:00
@mihailradkov mihailradkov force-pushed the GDB-9426-various-improvements-pt3 branch 2 times, most recently from ea85de5 to bcae5f3 Compare May 8, 2024 11:54
@mihailradkov mihailradkov requested a review from yaskoo May 8, 2024 13:50
@mihailradkov mihailradkov marked this pull request as ready for review May 8, 2024 13:50
- The javaArguments values are moved into another defaultJavaArguments
  to allow easier overriding with javaArguments
- Removed configuration overrides from the default `GDB_JAVA_OPTS`:
  `enable-context-index`, `entity-pool-implementation` and
  `health.max.query.time.seconds`
- Removed `default.min.distinct.threshold` from the default
  `defaultJavaArguments` values
- Added -XX:-UseCompressedOops
- Added `-XX:-UseCompressedOops` in the default Java arguments to allow
  allocating heap sizes larger than 32GBs when the max heap size is based
  on the `-XX:MaxRAMPercentage` Java option
- Added `updateStrategy` and `proxy.updateStrategy` for controlling the strategy when updating pods
- Added `podManagementPolicy` and `proxy.podManagementPolicy` for configuring how the pods are created and scaled
- Added `automountServiceAccountToken` with default value `false` effectively ejecting the service account token by default
- Added `schedulerName` and `proxy.schedulerName` for overriding the default Kubernetes scheduler
- Added `dnsConfig`, `dnsPolicy`, `proxy.dnsConfig` and `proxy.dnsPolicy` for customizing the DNS resolution if needed
- Added `proxy.initContainerSecurityContext` and `proxy.initContainerResources` to avoid using the configurations from GraphDB
- Ejected the default service account token in the proxy pods
- Added `extraContainers` and `proxy.extraContainers` for inserting additional containers into the pods of GraphDB and the GraphDB proxy
- Added `extraObjects` as a way to insert additional Kubernetes objects into the deployment
- Updated the chart to require Kubernetes version 1.24+
- Added `service.externalTrafficPolicy` and `service.proxy.externalTrafficPolicy`
  to override the policy to Local if needed
- Added `service.healthCheckNodePort` and `service.proxy.healthCheckNodePort` to
  define a specific node port for LB health checks
- Added `service.loadBalancerClass` and `service.proxy.loadBalancerClass` to select
  a specific load balancer implementation
- Added `service.loadBalancerSourceRanges` and `service.proxy.loadBalancerSourceRanges`
  to restrict the external ingress traffic from the LB
- Added `service.externalIPs` and `service.proxy.externalIPs` to use existing external IPs
- Added helper for printing warnings
- Renamed GraphDB storage PVC template name prefix to `storage` and server import folder to `import`
- Renamed all proxy volumes to start with graphdb-proxy-
Added configurations for extra `labels` and `annotations` for all persistent
volume claim templates: `persistence`, `proxy.persistence` and `import.volumeMount`
- Added `jobs.backoffLimit` for configuring the retry count for all jobs
- Added `jobs.ttlSecondsAfterFinished` for configuring the time in seconds for all jobs before deleting finished pods
- Added `jobs.persistence.emptyDir` configurations for the default temporary storage for all jobs
- Moved `provisioningUsername` and `provisioningPassword` under `security.provisioner`
- Added `security.provisioner.existingSecret` and `security.provisioner.tokenKey` to provide an existing authentication token
- Small bash script cleaning
@mihailradkov mihailradkov force-pushed the GDB-9426-various-improvements-pt3 branch from acaf00a to 134a005 Compare May 10, 2024 07:33
@mihailradkov mihailradkov force-pushed the GDB-9426-various-improvements-pt3 branch from 134a005 to c61c738 Compare May 10, 2024 07:35
@mihailradkov mihailradkov merged commit a5c93fc into GDB-9425-version-11 May 10, 2024
3 checks passed
@mihailradkov mihailradkov deleted the GDB-9426-various-improvements-pt3 branch May 10, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants