Bugfix for impersonation

As a superuser you can impersonate other institution admins. However in
the overview for MFA and secureID the current IdP was used and not the
impersonated IdP.

dashboard-gui/src/javascripts/components/app_list.jsx

@@ -302,7 +302,7 @@ export default function AppList({apps, currentUser, facets: remoteFacets, connec
     })
     if (!currentUser.guest) {
         facets.push(strongAuthenticationFacet)
-        const mfaEntities = currentUser.currentIdp.mfaEntities
+        const mfaEntities = currentUser.getCurrentIdp().mfaEntities
         const mfaLevels = [
             'https://refeds.org/profile/mfa',
             'http://schemas.microsoft.com/claims/multipleauthn'

dashboard-gui/src/javascripts/pages/authorization_policy_detail.jsx

@@ -72,7 +72,9 @@ export default function AuthorizationPolicyDetail({ app, type, onPolicyChange })
       if (e.response && e.response.json) {
         e.response.json().then((json) => {
           let message = 'error'
-          if (json.exception && json.exception.indexOf('PolicyNameNotUniqueException') > 0) {
+          if (json.exception && (
+              json.exception.indexOf('PolicyNameNotUniqueException') > 0 ||
+              json.exception.indexOf('DuplicateEntityIdException') > 0)) {
             message = I18n.t('policies.policy_name_not_unique_exception')
           }
           setFlash(message, 'error')

dashboard-gui/src/javascripts/pages/mfa.jsx

@@ -11,7 +11,7 @@ import ConnectModalContainer from "../components/connect_modal_container";
 
 export default function MFA({app}) {
     const {currentUser} = useContext(CurrentUserContext)
-    const mfaEntity = (currentUser.currentIdp.mfaEntities || []).find((e) => e.name === app.spEntityId)
+    const mfaEntity = (currentUser.getCurrentIdp().mfaEntities || []).find((e) => e.name === app.spEntityId)
     const initialAuthnContextLevel = mfaEntity && mfaEntity.level || ''
     const [authnContextLevel, setAuthnContextLevel] = useState(initialAuthnContextLevel)
     const [showStepUpModal, setShowStepUpModal] = useState(false)

dashboard-gui/src/javascripts/pages/stats.jsx

@@ -413,7 +413,7 @@ class Stats extends React.Component {
     const spSelected = sp !== this.allServiceProviderOption.value
     const noResult = (data.length === 1 && data[0] === 'no_results') || (loaded && data.length === 0)
     const results = loaded && data.length > 0 && !noResult
-    const idp = this.context.currentUser.currentIdp
+    const idp = this.context.currentUser.getCurrentIdp()
     const identityProvidersDict = {}
     identityProvidersDict[idp.id] =
       I18n.locale === 'en'

dashboard-gui/src/javascripts/pages/surf_secure_id.jsx

@@ -11,7 +11,7 @@ import ConnectModalContainer from "../components/connect_modal_container";
 
 export default function SurfSecureID({ app }) {
   const { currentUser } = useContext(CurrentUserContext)
-  const stepEntity = (currentUser.currentIdp.stepupEntities || []).find((e) => e.name === app.spEntityId)
+  const stepEntity = (currentUser.getCurrentIdp().stepupEntities || []).find((e) => e.name === app.spEntityId)
   const initialLoaLevel = app.minimalLoaLevel || (stepEntity && stepEntity.level) || ''
 
   const [loaLevel, setLoaLevel] = useState(initialLoaLevel)

dashboard-server/src/main/java/dashboard/service/impl/JiraTicketSummaryAndDescriptionBuilder.java

@@ -2,7 +2,6 @@
 
 import com.google.common.base.MoreObjects;
 import dashboard.domain.Action;
-import dashboard.domain.Change;
 import dashboard.domain.Settings;
 import dashboard.manage.ChangeRequest;
 import org.springframework.util.CollectionUtils;
@@ -11,7 +10,6 @@
 import java.text.SimpleDateFormat;
 import java.util.Date;
 import java.util.List;
-import java.util.Objects;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 import static dashboard.domain.Action.Type.*;
@@ -26,7 +24,9 @@ static SummaryAndDescription build(final Action action) {
         final StringBuilder summary = new StringBuilder();
 
         if (!CollectionUtils.isEmpty(action.getManageUrls())) {
-            description.append("A change request in manage has been created to merge this user request.See:\n" +
+            String changeRequestDescriiption = "A change request in manage has been created to merge this user request.";
+            String warning = action.getManageUrls().size() > 1 ? " NOTE: there are multiple Manage URL's." : "";
+            description.append(changeRequestDescriiption + warning + " See:\n" +
                     String.join("\n", action.getManageUrls()) + "\n\n");
         }