Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test b15 #1117

Merged
merged 5 commits into from
Feb 18, 2024
Merged

Test b15 #1117

merged 5 commits into from
Feb 18, 2024

Conversation

alfarj83
Copy link
Contributor

@alfarj83 alfarj83 commented Feb 16, 2024

Description

(Please include a summary of the change and which issue is touched on. Please also include relevant motivation and context.)

Partly Addresses #962

(In general, OED likes to have at least one issue associated with each pull request. Replace [issue] with the OED GitHub issue number. In the preview you will see an issue description if you hover over that number. You can create one yourself before doing this pull request. This is where details are normally given on what is being addressed. Note you should not use the word "Fixes" if it does not completely address the issue since the issue would automatically be closed on merging the pull request. In that case use "Partly Addresses #[issue].)

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • [] Note merging this changes the database configuration.
  • [] This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • [] I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

The rest of the test cases of bar meter flow needs to be done, but B15 needs no further review.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @alfarj83 for their first contribution to OED. Everything works as expected. There is one small comment to address and then this should be ready.

@huss
Copy link
Member

huss commented Feb 18, 2024

The update looks good. This is ready to merge. Congratulations on your first accepted contribution to OED.

@huss huss merged commit 0942298 into OpenEnergyDashboard:development Feb 18, 2024
3 checks passed
@alfarj83 alfarj83 deleted the test_B15 branch February 23, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants