Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement test LG12 #1118

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

andreybutenko
Copy link
Contributor

Description

Implement test LG12 according to specification in: https://github.com/OpenEnergyDashboard/DesignDocs/blob/main/testing/testing.md

Partly Addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Contributors

Limitations

n/a

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @andreybutenko, @Emc2Ikeda, @esu-skoopin & @seanfite for their first contribution to OED. The code look pretty good but I made a couple of comments that should be addressed. I note that other tests are currently failing on GitHub but I am fairly certain that is related to the changes you made and addressing the comments should fix this up. Please let me know if you need any help.

Co-authored-by: Ema Ikeda <e.mc2ikeda@gmail.com>
Co-authored-by: Emily Su <emilysu36@gmail.com>
Co-authored-by: Sean Fite <sean.fite@bellevuecollege.edu>
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @andreybutenko, @Emc2Ikeda, @esu-skoopin & @seanfite for the update. Review found it works as expected. Congratulations on your first accepted contribution to OED.

@huss huss merged commit 1ae7a4f into OpenEnergyDashboard:development Feb 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants