Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG3 test implementation #1119

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Conversation

AchsahJojo
Copy link
Contributor

  • Implementation of code for LG3: should have daily points for middle readings of 15 + 20 minute for a 61 day period and quantity units with kWh as kWh
  • Included relevant test data CSV

Co-authored by: Achsah Jojo achsahmaria.jojo@gmail.com
Co-authored by: Adrian Haro aharo1110@gmail.com
Co-authored by: Alireza Manizani amanizan@uci.edu

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @AchsahJojo, @aharo1110 & @aligence for their first contribution to OED. A code review and testing found no concerns and the test case runs as expected. This is ready to merge. Congratulations on your first accepted work into OED.

@huss huss merged commit 28be27f into OpenEnergyDashboard:development Feb 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants