Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG10 Testcase final #1122

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

sezavala
Copy link
Contributor

Description

My team and I are apart of the CodeDay micro-internship and we were tasked with the role of implementing LG 10. Our commit includes a new file with the expected values for which our testcase will be compared too, as well as our test case to validate the expected data from the API.

Fixes #962

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Implemented expected file
  • [ x] Implemented LG10 testcase

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • [] I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

Our test case is complete, but there are still some incomplete test cases.

Co-authored-by: Jean-luc Martel <jmartel@csumb.edu>
Co-authored-by: Ruxue Jin <ruxuejin21@gmail.com>
@huss
Copy link
Member

huss commented Feb 19, 2024

Thanks to @sezavala for this contribution to OED. The commit chain indicates that @Jean-LucMartel was an author of this code but I don't have a record of them agreeing to the CLA (let me know if you think this is wrong). Could they please do this so the work can be reviewed for acceptance. Let me know if you need anything.

@sezavala
Copy link
Contributor Author

@huss sorry about that, he just informed me that he has signed the CLA.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @sezavala, @RuxueJ & @Jean-LucMartel for their first contribution to OED. A review and testing found everything is fine. This is ready to merge. Congratulations on your first accepted code.

@huss huss merged commit 58b2b8a into OpenEnergyDashboard:development Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing readings
2 participants