Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LG21 test case and its expected csv file #1129

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

adedralin
Copy link
Contributor

Description

  • Implemented test case LG21 with description: "should have hourly points for middle readings of 15 + 20 minute for a 60 day period and quantity units & kWh as MJ"
  • Uploaded its appropriate CSV expected values file.

Co-authored by: @ChelsyLan, and Gyugang Lee

Partly Addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

@codingfiddler
Copy link

Also co-authored by @Username13555

@huss
Copy link
Member

huss commented Feb 23, 2024

Thanks to @adedralin, @ChelsyLan, @Username13555 & Gyugang Lee (I hope I have the names correct) for this contribution. I don't see a record that any of you signed the CLA. Assuming this is correct, please use the link in the description/Checklist to do this. If you think my records are wrong then please let me know.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @adedralin, @ChelsyLan & @Username13555 for their first contribution to OED. Review found it is fine and works as expected. Congratulations on your first accepted contribution to OED.

@huss huss merged commit 5e1a2d6 into OpenEnergyDashboard:development Mar 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants