Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LG20 test #1134

Merged
merged 9 commits into from
Mar 3, 2024
Merged

Conversation

GaryZLG
Copy link
Contributor

@GaryZLG GaryZLG commented Mar 3, 2024

Description

Implemented test case LG20 with description: "should have daily points for 15 + 20 minute reading intervals and quantity units with +-inf start/end time & kWh as lbs of CO2 & chained & reversed"
Uploaded its appropriate CSV expected values file.

Co-authored by: @stephanienguyen2020

Partly Addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

@huss
Copy link
Member

huss commented Mar 3, 2024

Thanks to @GaryZLG for their first pull request. I don't see a CLA by @stephanienguyen2020. Could they please do it by using the link in the Description/Checklist above. If you think my records are off then please let me know.

@stephanienguyen2020
Copy link

stephanienguyen2020 commented Mar 3, 2024

Thanks to @GaryZLG for their first pull request. I don't see a CLA by @stephanienguyen2020. Could they please do it by using the link in the Description/Checklist above. If you think my records are off then please let me know.

@huss Hi Steven, I just did. Can you please check?

@huss
Copy link
Member

huss commented Mar 3, 2024

Thanks to @GaryZLG for their first pull request. I don't see a CLA by @stephanienguyen2020. Could they please do it by using the link in the Description/Checklist above. If you think my records are off then please let me know.

@huss Hi Steven, I just did. Can you please check?

@stephanienguyen2020 Looks good. I have it. Thanks.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @GaryZLG & @stephanienguyen2020 for their first contribution to OED. Overall this looks good. I made one comment to resolve.

@GaryZLG
Copy link
Contributor Author

GaryZLG commented Mar 3, 2024

Thanks to @GaryZLG & @stephanienguyen2020 for their first contribution to OED. Overall this looks good. I made one comment to resolve.

Hi @huss , thanks for the changes requested for our code. I have replied to the reviewed conversation with my issue and my thoughts. I'm not familiar with the interface of Pull Request, so I'm not sure if I should click "Resolve Conversation". Could you please check my issue in the conversation replay and update with us for more information?

@huss
Copy link
Member

huss commented Mar 3, 2024

Thanks to @GaryZLG & @stephanienguyen2020 for their first contribution to OED. Overall this looks good. I made one comment to resolve.

Hi @huss , thanks for the changes requested for our code. I have replied to the reviewed conversation with my issue and my thoughts. I'm not familiar with the interface of Pull Request, so I'm not sure if I should click "Resolve Conversation". Could you please check my issue in the conversation replay and update with us for more information?

No problem. I added a comment and resolved.

@huss huss merged commit df360c9 into OpenEnergyDashboard:development Mar 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants