-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed test case CG2 #1366
Completed test case CG2 #1366
Conversation
Thanks to @BrendenHaskins, @lukeckk & @RaiuXL for their first contribution. My records don't show @lukeckk as having signed the OED CLA agreement that is needed as a coauthor of this work. Could you please do this or let me know if you already have. Once this is resolved the pull request can be reviewed. |
Hi Steve,
Thank you for reaching out! Just signed the CLA agreement, sorry about the
delay :)
…On Wed, Oct 23, 2024 at 12:35 PM Steven Huss-Lederman < ***@***.***> wrote:
Thanks to @BrendenHaskins <https://github.com/BrendenHaskins>, @lukeckk
<https://github.com/lukeckk> & @RaiuXL <https://github.com/RaiuXL> for
their first contribution. My records don't show @lukeckk
<https://github.com/lukeckk> as having signed the OED CLA agreement that
is needed as a coauthor of this work. Could you please do this or let me
know if you already have. Once this is resolved the pull request can be
reviewed.
—
Reply to this email directly, view it on GitHub
<#1366 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2D5GGTUSZ64WGHA7LLCO3TZ473B3AVCNFSM6AAAAABQNGMCPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZTGI3TOMBXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
For the record, I pushed a very small change to the test titles so all are consistent with what OED wants. It turns out that I missed this on previous tests in this file so did it. The original code in this PR was consistent with the other code which made sense but OED wanted something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, I want to apologize to @BrendenHaskins, @lukeckk & @RaiuXL for not reviewing this sooner. Somehow I lost tract that it was ready. Second, review and testing found it works as desired. Congratulations on your first accepted code into OED.
Awesome! Thanks Steven !
…On Tue, Oct 29, 2024 at 3:14 PM Steven Huss-Lederman < ***@***.***> wrote:
Merged #1366 <#1366> into
development.
—
Reply to this email directly, view it on GitHub
<#1366 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2D5GGULZTGSFNKRD6PCWPLZ6ACFBAVCNFSM6AAAAABQNGMCPWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUHE4TCOJRGE4TAMY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
Adds mocha test for test case CG2 into readingsCompareGroupQuantity.js (src/server/test/web)
This PR would require a change in DesignDocs/testing/testing.md to show CG2 as complete.
With the help of @lukeckk, @RaiuXL
Partially Addresses #962
Type of change
Checklist
Limitations
This is only one of the compare group tests.