Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed test case CG2 #1366

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Completed test case CG2 #1366

merged 2 commits into from
Oct 29, 2024

Conversation

BrendenHaskins
Copy link
Contributor

@BrendenHaskins BrendenHaskins commented Oct 22, 2024

Description

Adds mocha test for test case CG2 into readingsCompareGroupQuantity.js (src/server/test/web)
This PR would require a change in DesignDocs/testing/testing.md to show CG2 as complete.
With the help of @lukeckk, @RaiuXL

Partially Addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the [OED Contributing License Agreement] and each author is listed in the Description section.

Limitations

This is only one of the compare group tests.

@huss
Copy link
Member

huss commented Oct 23, 2024

Thanks to @BrendenHaskins, @lukeckk & @RaiuXL for their first contribution. My records don't show @lukeckk as having signed the OED CLA agreement that is needed as a coauthor of this work. Could you please do this or let me know if you already have. Once this is resolved the pull request can be reviewed.

@lukeckk
Copy link
Contributor

lukeckk commented Oct 23, 2024 via email

@BrendenHaskins BrendenHaskins marked this pull request as ready for review October 24, 2024 21:04
@huss
Copy link
Member

huss commented Oct 29, 2024

For the record, I pushed a very small change to the test titles so all are consistent with what OED wants. It turns out that I missed this on previous tests in this file so did it. The original code in this PR was consistent with the other code which made sense but OED wanted something else.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, I want to apologize to @BrendenHaskins, @lukeckk & @RaiuXL for not reviewing this sooner. Somehow I lost tract that it was ready. Second, review and testing found it works as desired. Congratulations on your first accepted code into OED.

@huss huss merged commit 72a2431 into OpenEnergyDashboard:development Oct 29, 2024
3 checks passed
@lukeckk
Copy link
Contributor

lukeckk commented Oct 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants