Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests JS objects and DB Enums in sync for Issue #562 #1399

Merged
merged 11 commits into from
Dec 5, 2024

Conversation

EBoyd3443
Copy link
Contributor

Description

Added new file enumTests.js with tests to make sure JS objects match DB enums including:

  • Meter.type
  • Unit.displayableType
  • User.role
  • Unit.areaUnitType
  • Unit.unitType

David Jarvis - @DPJProgramming
Dale - @dalejk88
Eric - @eboyd3443
Garrett Ballreich - @Gballreich

Partly addresses Issue #562

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

Tests for equivalency between TS enums and JS and/or database still need to be made.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @DPJProgramming, @dalejk88, @EBoyd3443 & @Gballreich for addressing this issue. Review and testing found it works as expected and tests all relevant enums. Congratulations on another accepted contribution.

@huss huss merged commit 03ede78 into OpenEnergyDashboard:development Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants